Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Side by Side Diff: runtime/vm/service.cc

Issue 1285643004: Allow stepping when paused at isolate start. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/service.h" 5 #include "vm/service.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "include/dart_native_api.h" 8 #include "include/dart_native_api.h"
9 #include "platform/globals.h" 9 #include "platform/globals.h"
10 10
(...skipping 2290 matching lines...) Expand 10 before | Expand all | Expand 10 after
2301 2301
2302 static const MethodParameter* resume_params[] = { 2302 static const MethodParameter* resume_params[] = {
2303 ISOLATE_PARAMETER, 2303 ISOLATE_PARAMETER,
2304 NULL, 2304 NULL,
2305 }; 2305 };
2306 2306
2307 2307
2308 static bool Resume(Isolate* isolate, JSONStream* js) { 2308 static bool Resume(Isolate* isolate, JSONStream* js) {
2309 const char* step_param = js->LookupParam("step"); 2309 const char* step_param = js->LookupParam("step");
2310 if (isolate->message_handler()->paused_on_start()) { 2310 if (isolate->message_handler()->paused_on_start()) {
2311 // If the user is issuing a 'Over' or an 'Out' step, that is the
2312 // same as a regular resume request.
2313 if ((step_param != NULL) && (strcmp(step_param, "Into") == 0)) {
2314 isolate->debugger()->EnterSingleStepMode();
2315 }
2311 isolate->message_handler()->set_pause_on_start(false); 2316 isolate->message_handler()->set_pause_on_start(false);
2312 if (Service::debug_stream.enabled()) { 2317 if (Service::debug_stream.enabled()) {
2313 ServiceEvent event(isolate, ServiceEvent::kResume); 2318 ServiceEvent event(isolate, ServiceEvent::kResume);
2314 Service::HandleEvent(&event); 2319 Service::HandleEvent(&event);
2315 } 2320 }
2316 PrintSuccess(js); 2321 PrintSuccess(js);
2317 return true; 2322 return true;
2318 } 2323 }
2319 if (isolate->message_handler()->paused_on_exit()) { 2324 if (isolate->message_handler()->paused_on_exit()) {
2320 isolate->message_handler()->set_pause_on_exit(false); 2325 isolate->message_handler()->set_pause_on_exit(false);
(...skipping 813 matching lines...) Expand 10 before | Expand all | Expand 10 after
3134 ServiceMethodDescriptor& method = service_methods_[i]; 3139 ServiceMethodDescriptor& method = service_methods_[i];
3135 if (strcmp(method_name, method.name) == 0) { 3140 if (strcmp(method_name, method.name) == 0) {
3136 return &method; 3141 return &method;
3137 } 3142 }
3138 } 3143 }
3139 return NULL; 3144 return NULL;
3140 } 3145 }
3141 3146
3142 3147
3143 } // namespace dart 3148 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/debugger.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698