Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 12855003: Add safetymargin for timer tests in browsers. (Closed)

Created:
7 years, 9 months ago by floitsch
Modified:
7 years, 9 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Add safetymargin for timer tests in browsers. Committed: https://code.google.com/p/dart/source/detail?r=20209

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Patch Set 3 : Fix return type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M tests/lib/async/multiple_timer_test.dart View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M tests/lib/async/timer_test.dart View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
7 years, 9 months ago (2013-03-19 14:39:50 UTC) #1
ricow1
LGTM https://codereview.chromium.org/12855003/diff/1/tests/lib/async/multiple_timer_test.dart File tests/lib/async/multiple_timer_test.dart (right): https://codereview.chromium.org/12855003/diff/1/tests/lib/async/multiple_timer_test.dart#newcode17 tests/lib/async/multiple_timer_test.dart:17: how about: bool get timerSafetyMargin => isCompiledByDart2Js ? ...
7 years, 9 months ago (2013-03-19 14:45:12 UTC) #2
floitsch
https://codereview.chromium.org/12855003/diff/1/tests/lib/async/multiple_timer_test.dart File tests/lib/async/multiple_timer_test.dart (right): https://codereview.chromium.org/12855003/diff/1/tests/lib/async/multiple_timer_test.dart#newcode17 tests/lib/async/multiple_timer_test.dart:17: On 2013/03/19 14:45:12, ricow1 wrote: > how about: > ...
7 years, 9 months ago (2013-03-19 14:47:58 UTC) #3
floitsch
7 years, 9 months ago (2013-03-19 15:13:38 UTC) #4
floitsch
7 years, 9 months ago (2013-03-19 15:13:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r20209 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698