Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: tests/lib/async/multiple_timer_test.dart

Issue 12855003: Add safetymargin for timer tests in browsers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix return type. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/lib/async/timer_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library multiple_timer_test; 5 library multiple_timer_test;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import '../../../pkg/unittest/lib/unittest.dart'; 8 import '../../../pkg/unittest/lib/unittest.dart';
9 9
10 const Duration TIMEOUT1 = const Duration(seconds: 1); 10 const Duration TIMEOUT1 = const Duration(seconds: 1);
11 const Duration TIMEOUT2 = const Duration(seconds: 2); 11 const Duration TIMEOUT2 = const Duration(seconds: 2);
12 const Duration TIMEOUT3 = const Duration(milliseconds: 500); 12 const Duration TIMEOUT3 = const Duration(milliseconds: 500);
13 const Duration TIMEOUT4 = const Duration(milliseconds: 1500); 13 const Duration TIMEOUT4 = const Duration(milliseconds: 1500);
14 14
15 // The stopwatch is more precise than the Timer. It can happen that
16 // the TIMEOUT triggers *slightly* too early on the VM. So we add a millisecond
17 // as safetymargin.
18 // Some browsers (Firefox and IE so far) can trigger too early. So we add more
19 // margin. We use identical(1, 1.0) as an easy way to know if the test is
20 // compiled by dart2js.
21 int get safetyMargin => identical(1, 1.0) ? 1 : 100;
22
15 main() { 23 main() {
16 test("multiple timer test", () { 24 test("multiple timer test", () {
17 Stopwatch _stopwatch1 = new Stopwatch(); 25 Stopwatch _stopwatch1 = new Stopwatch();
18 Stopwatch _stopwatch2 = new Stopwatch(); 26 Stopwatch _stopwatch2 = new Stopwatch();
19 Stopwatch _stopwatch3 = new Stopwatch(); 27 Stopwatch _stopwatch3 = new Stopwatch();
20 Stopwatch _stopwatch4 = new Stopwatch(); 28 Stopwatch _stopwatch4 = new Stopwatch();
21 List<int> _order; 29 List<int> _order;
22 int _message; 30 int _message;
23 31
24 void timeoutHandler1() { 32 void timeoutHandler1() {
25 // The stopwatch is more precise than the Timer. It can happen that 33 expect(_stopwatch1.elapsedMilliseconds + safetyMargin,
26 // the TIMEOUT triggers *slightly* too early.
27 expect(_stopwatch1.elapsedMilliseconds + 1,
28 greaterThanOrEqualTo(TIMEOUT1.inMilliseconds)); 34 greaterThanOrEqualTo(TIMEOUT1.inMilliseconds));
29 expect(_order[_message], 0); 35 expect(_order[_message], 0);
30 _message++; 36 _message++;
31 } 37 }
32 38
33 void timeoutHandler2() { 39 void timeoutHandler2() {
34 // The stopwatch is more precise than the Timer. It can happen that 40 expect(_stopwatch2.elapsedMilliseconds + safetyMargin,
35 // the TIMEOUT triggers *slightly* too early.
36 expect(_stopwatch2.elapsedMilliseconds + 1,
37 greaterThanOrEqualTo(TIMEOUT2.inMilliseconds)); 41 greaterThanOrEqualTo(TIMEOUT2.inMilliseconds));
38 expect(_order[_message], 1); 42 expect(_order[_message], 1);
39 _message++; 43 _message++;
40 } 44 }
41 45
42 void timeoutHandler3() { 46 void timeoutHandler3() {
43 // The stopwatch is more precise than the Timer. It can happen that 47 expect(_stopwatch3.elapsedMilliseconds + safetyMargin,
44 // the TIMEOUT triggers *slightly* too early.
45 expect(_stopwatch3.elapsedMilliseconds + 1,
46 greaterThanOrEqualTo(TIMEOUT3.inMilliseconds)); 48 greaterThanOrEqualTo(TIMEOUT3.inMilliseconds));
47 expect(_order[_message], 2); 49 expect(_order[_message], 2);
48 _message++; 50 _message++;
49 } 51 }
50 52
51 void timeoutHandler4() { 53 void timeoutHandler4() {
52 // The stopwatch is more precise than the Timer. It can happen that 54 expect(_stopwatch4.elapsedMilliseconds + safetyMargin,
53 // the TIMEOUT triggers *slightly* too early.
54 expect(_stopwatch4.elapsedMilliseconds + 1,
55 greaterThanOrEqualTo(TIMEOUT4.inMilliseconds)); 55 greaterThanOrEqualTo(TIMEOUT4.inMilliseconds));
56 expect(_order[_message], 3); 56 expect(_order[_message], 3);
57 _message++; 57 _message++;
58 } 58 }
59 59
60 _order = new List<int>(4); 60 _order = new List<int>(4);
61 _order[0] = 2; 61 _order[0] = 2;
62 _order[1] = 0; 62 _order[1] = 0;
63 _order[2] = 3; 63 _order[2] = 3;
64 _order[3] = 1; 64 _order[3] = 1;
65 _message = 0; 65 _message = 0;
66 66
67 _stopwatch1.start(); 67 _stopwatch1.start();
68 new Timer(TIMEOUT1, expectAsync0(timeoutHandler1)); 68 new Timer(TIMEOUT1, expectAsync0(timeoutHandler1));
69 _stopwatch2.start(); 69 _stopwatch2.start();
70 new Timer(TIMEOUT2, expectAsync0(timeoutHandler2)); 70 new Timer(TIMEOUT2, expectAsync0(timeoutHandler2));
71 _stopwatch3.start(); 71 _stopwatch3.start();
72 new Timer(TIMEOUT3, expectAsync0(timeoutHandler3)); 72 new Timer(TIMEOUT3, expectAsync0(timeoutHandler3));
73 _stopwatch4.start(); 73 _stopwatch4.start();
74 new Timer(TIMEOUT4, expectAsync0(timeoutHandler4)); 74 new Timer(TIMEOUT4, expectAsync0(timeoutHandler4));
75 }); 75 });
76 } 76 }
OLDNEW
« no previous file with comments | « no previous file | tests/lib/async/timer_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698