Issue 1284933002: More tweaks in attempt to debug the reason of failing getNavigation() tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1284933002: More tweaks in attempt to debug the reason of failing getNavigation() tests. (Closed)

Created:
5 years, 4 months ago by scheglov

Modified:
5 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

More tweaks in attempt to debug the reason of failing getNavigation() tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e9d2f739ada7d77e5a8ddbf28ab00649d333aeb9

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -34 lines)			Patch
M	pkg/analysis_server/lib/src/domain_analysis.dart	View	1 chunk	+37 lines, -29 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/get_navigation_test.dart	View	6 chunks	+7 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/mocks.dart	View	3 chunks	+5 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1284933002/diff/1/pkg/analysis_server/test/mocks.dart File pkg/analysis_server/test/mocks.dart (right): https://codereview.chromium.org/1284933002/diff/1/pkg/analysis_server/test/mocks.dart#newcode61 pkg/analysis_server/test/mocks.dart:61: Future pumpEventQueue([int times = 5000]) { I'm a ...

5 years, 4 months ago (2015-08-11 18:13:01 UTC) #2

scheglov

5 years, 4 months ago (2015-08-11 18:13:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e9d2f739ada7d77e5a8ddbf28ab00649d333aeb9 (presubmit successful).

Expand Messages | Collapse Messages