Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: pkg/analysis_server/lib/src/domain_analysis.dart

Issue 1284933002: More tweaks in attempt to debug the reason of failing getNavigation() tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_analysis.dart
diff --git a/pkg/analysis_server/lib/src/domain_analysis.dart b/pkg/analysis_server/lib/src/domain_analysis.dart
index 78572edeff8580afd8df209f973fe41ffe62862b..955f0ced429856013711b7a754d0fdf6430fbac1 100644
--- a/pkg/analysis_server/lib/src/domain_analysis.dart
+++ b/pkg/analysis_server/lib/src/domain_analysis.dart
@@ -118,38 +118,46 @@ class AnalysisDomainHandler implements RequestHandler {
return new Response.getNavigationInvalidFile(request);
}
analysisFuture.then((AnalysisDoneReason reason) {
- switch (reason) {
- case AnalysisDoneReason.COMPLETE:
- print('AnalysisDoneReason.COMPLETE');
- List<CompilationUnit> units =
- server.getResolvedCompilationUnits(file);
- print('units: $units');
- if (units.isEmpty) {
- server.sendResponse(new Response.getNavigationInvalidFile(request));
- } else {
- DartUnitNavigationComputer computer =
- new DartUnitNavigationComputer();
- _GetNavigationAstVisitor visitor = new _GetNavigationAstVisitor(
- params.offset, params.offset + params.length, computer);
- for (CompilationUnit unit in units) {
- unit.accept(visitor);
+ print(' reason: $reason');
+ try {
+ switch (reason) {
+ case AnalysisDoneReason.COMPLETE:
+ print(' AnalysisDoneReason.COMPLETE');
+ List<CompilationUnit> units =
+ server.getResolvedCompilationUnits(file);
+ print(' units: $units');
+ if (units.isEmpty) {
+ server
+ .sendResponse(new Response.getNavigationInvalidFile(request));
+ } else {
+ DartUnitNavigationComputer computer =
+ new DartUnitNavigationComputer();
+ _GetNavigationAstVisitor visitor = new _GetNavigationAstVisitor(
+ params.offset, params.offset + params.length, computer);
+ for (CompilationUnit unit in units) {
+ unit.accept(visitor);
+ }
+ server.sendResponse(new AnalysisGetNavigationResult(
+ computer.files, computer.targets, computer.regions)
+ .toResponse(request.id));
}
- server.sendResponse(new AnalysisGetNavigationResult(
- computer.files, computer.targets, computer.regions)
- .toResponse(request.id));
- }
- break;
- case AnalysisDoneReason.CONTEXT_REMOVED:
- print('AnalysisDoneReason.CONTEXT_REMOVED');
- // The active contexts have changed, so try again.
- Response response = getNavigation(request);
- if (response != Response.DELAYED_RESPONSE) {
- server.sendResponse(response);
- }
- break;
+ break;
+ case AnalysisDoneReason.CONTEXT_REMOVED:
+ print(' AnalysisDoneReason.CONTEXT_REMOVED');
+ // The active contexts have changed, so try again.
+ Response response = getNavigation(request);
+ if (response != Response.DELAYED_RESPONSE) {
+ server.sendResponse(response);
+ }
+ break;
+ }
+ } on Exception catch (e, st) {
+ print('Exception1 in AnalysisDomainHandler.getNavigation()');
+ print(e);
+ print(st);
}
}).catchError((e, st) {
- print('Exception in AnalysisDomainHandler.getNavigation()');
+ print('Exception2 in AnalysisDomainHandler.getNavigation()');
print(e);
print(st);
});
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis/get_navigation_test.dart » ('j') | pkg/analysis_server/test/mocks.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698