Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 128443003: Analyzer snapshot. (Closed)

Created:
6 years, 11 months ago by scheglov
Modified:
6 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Analyzer snapshot. Rewrite TimeCounter to use Stopwatch. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=31623

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixes for review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1715 lines, -209 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilder.java View 1 chunk +19 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java View 1 2 chunks +10 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/general/StringUtilities.java View 2 chunks +7 lines, -8 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +4 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_engine.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 1 4 chunks +47 lines, -5 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/GuavaSemanticProcessor.java View 2 chunks +10 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/GuavaSemanticProcessorTest.java View 1 chunk +51 lines, -0 lines 0 comments Download
M pkg/analyzer/bin/analyzer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 3 chunks +23 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 1 20 chunks +462 lines, -37 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 5 chunks +12 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 15 chunks +105 lines, -19 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 13 chunks +59 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/generated/instrumentation.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/java_engine.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 8 chunks +12 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 23 chunks +668 lines, -40 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_general.dart View 2 chunks +7 lines, -11 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 4 chunks +69 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 4 chunks +16 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 14 chunks +43 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 7 chunks +26 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 11 months ago (2014-01-08 17:42:03 UTC) #1
Brian Wilkerson
LGTM. Does this roll up changes from previous (but uncommitted) CL's? https://codereview.chromium.org/128443003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java (right): ...
6 years, 11 months ago (2014-01-08 18:31:55 UTC) #2
scheglov
https://codereview.chromium.org/128443003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java (right): https://codereview.chromium.org/128443003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java#newcode77 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java:77: return unit.getToolkitObjects(this); On 2014/01/08 18:31:56, Brian Wilkerson wrote: > ...
6 years, 11 months ago (2014-01-08 20:27:28 UTC) #3
scheglov
6 years, 11 months ago (2014-01-08 20:28:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r31623 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698