editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/GuavaSemanticProcessor.java - Issue 128443003: Analyzer snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/GuavaSemanticProcessor.java

Issue 128443003: Analyzer snapshot. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes for review comments. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java ('k') | editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/GuavaSemanticProcessorTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/GuavaSemanticProcessor.java

diff --git a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/GuavaSemanticProcessor.java b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/GuavaSemanticProcessor.java

index 25698e35617619bafb12154fe03f9d870d468475..e4d3026238b3a53410f87ef42b4ca7137c25d884 100644

--- a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/GuavaSemanticProcessor.java

+++ b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/GuavaSemanticProcessor.java

@@ -24,6 +24,8 @@ import com.google.dart.java2dart.Context;

import static com.google.dart.java2dart.util.ASTFactory.binaryExpression;

import static com.google.dart.java2dart.util.ASTFactory.instanceCreationExpression;

+import static com.google.dart.java2dart.util.ASTFactory.listLiteral;

+import static com.google.dart.java2dart.util.ASTFactory.mapLiteral;

import static com.google.dart.java2dart.util.ASTFactory.typeName;

import java.util.List;

@@ -51,6 +53,14 @@ public class GuavaSemanticProcessor extends SemanticProcessor {

replaceNode(node, instanceCreationExpression(Keyword.NEW, typeName("Map")));

return null;

}

+ if (isMethodInClass(node, "newArrayList", "com.google.common.collect.Lists")) {

+ replaceNode(node, listLiteral());

+ return null;

+ }

+ if (isMethodInClass(node, "newHashMap", "com.google.common.collect.Maps")) {

+ replaceNode(node, mapLiteral());

+ return null;

+ }

if (isMethodInClass(node, "newHashSet", "com.google.common.collect.Sets")) {

replaceNode(node, instanceCreationExpression(Keyword.NEW, typeName("Set")));

return null;