Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284263002: Start TimelineAnalysis utility (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Start TimelineAnalysis utility - Add TimelineEventBlockIterator - iterate over TimelineEventBlocks. - Add TimelineAnalysisThread - All events for a specific thread. - Add TimelineAnalysis - Utility for analyzing timeline events. - Add unit test for TimelineAnalysis thread discovery and block sorting. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4511599443173f550f0588f6681bd28e6dc963b7

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+463 lines, -8 lines) Patch
M runtime/vm/timeline.h View 1 7 chunks +45 lines, -0 lines 0 comments Download
M runtime/vm/timeline.cc View 1 2 chunks +76 lines, -1 line 0 comments Download
A runtime/vm/timeline_analysis.h View 1 chunk +99 lines, -0 lines 0 comments Download
A runtime/vm/timeline_analysis.cc View 1 1 chunk +139 lines, -0 lines 0 comments Download
M runtime/vm/timeline_test.cc View 1 2 3 chunks +84 lines, -0 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/zone.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/zone.cc View 1 chunk +16 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 4 months ago (2015-08-12 14:47:14 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1284263002/diff/20001/runtime/vm/timeline_test.cc File runtime/vm/timeline_test.cc (right): https://codereview.chromium.org/1284263002/diff/20001/runtime/vm/timeline_test.cc#newcode279 runtime/vm/timeline_test.cc:279: // block_c_0 is never used by a thread, ...
5 years, 4 months ago (2015-08-12 19:51:47 UTC) #3
Cutch
https://codereview.chromium.org/1284263002/diff/20001/runtime/vm/timeline_test.cc File runtime/vm/timeline_test.cc (right): https://codereview.chromium.org/1284263002/diff/20001/runtime/vm/timeline_test.cc#newcode279 runtime/vm/timeline_test.cc:279: // block_c_0 is never used by a thread, so ...
5 years, 4 months ago (2015-08-12 20:31:19 UTC) #4
Cutch
5 years, 4 months ago (2015-08-12 20:31:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
4511599443173f550f0588f6681bd28e6dc963b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698