Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: runtime/vm/timeline.h

Issue 1284263002: Start TimelineAnalysis utility (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/timeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline.h
diff --git a/runtime/vm/timeline.h b/runtime/vm/timeline.h
index 1995cfce551ca6fb6053fcdf7df3d0ac1321f45a..3447ce1491f7549e65c965f14609c8d0c487f433 100644
--- a/runtime/vm/timeline.h
+++ b/runtime/vm/timeline.h
@@ -5,12 +5,16 @@
#ifndef VM_TIMELINE_H_
#define VM_TIMELINE_H_
+#include "vm/allocation.h"
#include "vm/bitfield.h"
namespace dart {
+class JSONArray;
+class JSONObject;
class JSONStream;
class Object;
+class ObjectPointerVisitor;
class RawArray;
class Thread;
class TimelineEvent;
@@ -83,6 +87,10 @@ class TimelineEvent {
void PrintJSON(JSONStream* stream) const;
+ ThreadId thread() const {
+ return thread_;
+ }
+
private:
struct TimelineEventArgument {
const char* name;
@@ -276,6 +284,10 @@ class TimelineEventBlock {
return length_;
}
+ bool IsEmpty() const {
+ return length_ == 0;
+ }
+
bool IsFull() const {
return length_ == kBlockSize;
}
@@ -286,6 +298,16 @@ class TimelineEventBlock {
return &events_[index];
}
+ // Attempt to sniff a thread id from the first event.
+ ThreadId thread() const;
+ // Attempt to sniff the timestamp from the first event.
+ int64_t LowerTimeBound() const;
+
+ // Returns false if |this| violates any of the following invariants:
+ // - events in the block come from one thread.
+ // - events have monotonically increasing timestamps.
+ bool CheckBlock();
+
protected:
TimelineEvent* StartEvent();
@@ -294,6 +316,7 @@ class TimelineEventBlock {
intptr_t length_;
friend class TimelineEventEndlessRecorder;
+ friend class TimelineTestHelper;
private:
DISALLOW_COPY_AND_ASSIGN(TimelineEventBlock);
@@ -336,6 +359,7 @@ class TimelineEventRecorder {
// A recorder that stores events in a ring buffer of fixed capacity.
// This recorder does track Dart objects.
+// TODO(johnmccutchan): Make this recorder use event blocks too.
class TimelineEventRingRecorder : public TimelineEventRecorder {
public:
static const intptr_t kDefaultCapacity = 8192;
@@ -417,6 +441,27 @@ class TimelineEventEndlessRecorder : public TimelineEventRecorder {
Mutex lock_;
TimelineEventBlock* head_;
+
+ friend class TimelineEventBlockIterator;
+};
+
+
+// An iterator for blocks.
+class TimelineEventBlockIterator {
+ public:
+ explicit TimelineEventBlockIterator(TimelineEventEndlessRecorder* recorder);
+ ~TimelineEventBlockIterator();
+
+ void Reset();
+ bool Next();
+
+ TimelineEventBlock* current() const {
+ return current_;
+ }
+
+ private:
+ TimelineEventBlock* current_;
+ TimelineEventEndlessRecorder* recorder_;
};
} // namespace dart
« no previous file with comments | « no previous file | runtime/vm/timeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698