Issue 1284223005: Forward cancel subscription in stream pipes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1284223005: Forward cancel subscription in stream pipes. (Closed)

Created:
5 years, 4 months ago by floitsch

Modified:
5 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, hausner

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Forward cancel subscription in stream pipes. R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/ad38b75bb2ef80317a5b57f6d30e965791ea36de

Patch Set 2 : Update status file. #

Total comments: 1

Patch Set 3 : Address comment. #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -17 lines)			Patch
M	sdk/lib/async/stream_pipe.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/async_star_regression_fisk_test.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
A +	tests/lib/async/wait_for_cancel_test.dart	View	1 2	1 chunk	+12 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

LGTM. Good catch. https://codereview.chromium.org/1284223005/diff/20001/tests/lib/async/wait_for_cancel_test.dart File tests/lib/async/wait_for_cancel_test.dart (right): https://codereview.chromium.org/1284223005/diff/20001/tests/lib/async/wait_for_cancel_test.dart#newcode17 tests/lib/async/wait_for_cancel_test.dart:17: Expect.fail("listen should not be called"); listen ...

5 years, 4 months ago (2015-08-13 05:45:32 UTC) #4

floitsch

5 years, 4 months ago (2015-08-13 10:57:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
ad38b75bb2ef80317a5b57f6d30e965791ea36de (presubmit successful).