sdk/lib/async/stream_pipe.dart - Issue 1284223005: Forward cancel subscription in stream pipes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/async/stream_pipe.dart

Issue 1284223005: Forward cancel subscription in stream pipes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comment. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/async/stream_pipe.dart

diff --git a/sdk/lib/async/stream_pipe.dart b/sdk/lib/async/stream_pipe.dart

index a2fc15d5e3adbfe84a89494c940f4dc7f9d96e82..b3c3aaf18b933521c81d31fd25387cc95c3f4a29 100644

--- a/sdk/lib/async/stream_pipe.dart

+++ b/sdk/lib/async/stream_pipe.dart

@@ -161,7 +161,7 @@ class _ForwardingStreamSubscription<S, T>

if (_subscription != null) {

StreamSubscription subscription = _subscription;

_subscription = null;

- subscription.cancel();

+ return subscription.cancel();

}

return null;

}

« no previous file with comments | « no previous file | tests/language/async_star_regression_fisk_test.dart » ('j') | no next file with comments »