Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1282993002: Don't use %p when generating disassembly in vm service. (Closed)

Created:
5 years, 4 months ago by turnidge
Modified:
5 years, 4 months ago
Reviewers:
Cutch, Ivan Posva
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't use %p when generating disassembly in vm service. Evidentally it is platform dependent -- it seems to include the 0x prefix on mac but not on windows. I've switched to using %" Px " instead. This will fix bug 24038. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/cc981c8246e28e21fe84b8ec00b7a2eac9719102

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Pp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/service.status View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/platform/globals.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/disassembler.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
turnidge
5 years, 4 months ago (2015-08-10 23:41:53 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-08-10 23:50:02 UTC) #3
Ivan Posva
https://codereview.chromium.org/1282993002/diff/40001/runtime/vm/disassembler.cc File runtime/vm/disassembler.cc (right): https://codereview.chromium.org/1282993002/diff/40001/runtime/vm/disassembler.cc#newcode53 runtime/vm/disassembler.cc:53: jsarr_.AddValueF("%" Px "", pc); I don't think this is ...
5 years, 4 months ago (2015-08-11 01:17:40 UTC) #5
turnidge
5 years, 4 months ago (2015-08-11 18:22:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
cc981c8246e28e21fe84b8ec00b7a2eac9719102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698