Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1282993002: Don't use %p when generating disassembly in vm service. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Pp Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/service.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 77599a75bb2c9fc2ec12d846deee48f60cb7c196..7afd69a3e878a409b4f041b19aca762f8175cd1f 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -3357,7 +3357,7 @@ class Code extends HeapObject {
var pcOffset = 0;
if (disassembly[i] != '') {
// Not a code comment, extract address.
- address = int.parse(disassembly[i]);
+ address = int.parse(disassembly[i], radix:16);
pcOffset = address - startAddress;
}
var instruction = new CodeInstruction(address, pcOffset, machine, human);
« no previous file with comments | « no previous file | runtime/observatory/tests/service/service.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698