Issue 12827027: Revert "Compute local variable liveness before translation to SSA."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12827027: Revert "Compute local variable liveness before translation to SSA." (Closed)

Created:
7 years, 9 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 9 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Compute local variable liveness before translation to SSA." Attaching environments to branches on strict comparisons breaks pattern matching in the optimizer and regresses performance. This reverts commit r20377. TBR=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=20400

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+207 lines, -396 lines)			Patch
M	runtime/vm/bit_vector.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/bit_vector.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/bit_vector_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/compiler.cc	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View	3 chunks	+1 line, -76 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	8 chunks	+13 lines, -243 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.h	View	5 chunks	+37 lines, -17 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	10 chunks	+102 lines, -16 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	8 chunks	+14 lines, -16 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	4 chunks	+34 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

7 years, 9 months ago (2013-03-22 18:32:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r20400 (presubmit successful).

Expand Messages | Collapse Messages