Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: runtime/vm/flow_graph.h

Issue 12827027: Revert "Compute local variable liveness before translation to SSA." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph.h
diff --git a/runtime/vm/flow_graph.h b/runtime/vm/flow_graph.h
index e95e269b8c65bb40cef5a048f0fbb53a08495e1f..a3c02354362960fed68b4ae1e800ab7c1e82a632 100644
--- a/runtime/vm/flow_graph.h
+++ b/runtime/vm/flow_graph.h
@@ -13,7 +13,6 @@ namespace dart {
class FlowGraphBuilder;
class ValueInliningContext;
-class VariableLivenessAnalysis;
class BlockIterator : public ValueObject {
public:
@@ -163,14 +162,11 @@ class FlowGraph : public ZoneAllocated {
GrowableArray<intptr_t>* label);
void Rename(GrowableArray<PhiInstr*>* live_phis,
- VariableLivenessAnalysis* variable_liveness,
GrowableArray<Definition*>* inlining_parameters);
-
void RenameRecursive(
BlockEntryInstr* block_entry,
GrowableArray<Definition*>* env,
- GrowableArray<PhiInstr*>* live_phis,
- VariableLivenessAnalysis* variable_liveness);
+ GrowableArray<PhiInstr*>* live_phis);
void InsertPhis(
const GrowableArray<BlockEntryInstr*>& preorder,
@@ -203,77 +199,6 @@ class FlowGraph : public ZoneAllocated {
ConstantInstr* constant_null_;
};
-
-class LivenessAnalysis : public ValueObject {
- public:
- LivenessAnalysis(intptr_t variable_count,
- const GrowableArray<BlockEntryInstr*>& postorder);
-
- void Analyze();
-
- virtual ~LivenessAnalysis() { }
-
- BitVector* GetLiveInSetAt(intptr_t postorder_number) const {
- return live_in_[postorder_number];
- }
-
- BitVector* GetLiveOutSetAt(intptr_t postorder_number) const {
- return live_out_[postorder_number];
- }
-
- BitVector* GetLiveInSet(BlockEntryInstr* block) const {
- return GetLiveInSetAt(block->postorder_number());
- }
-
- BitVector* GetKillSet(BlockEntryInstr* block) const {
- return kill_[block->postorder_number()];
- }
-
- BitVector* GetLiveOutSet(BlockEntryInstr* block) const {
- return GetLiveOutSetAt(block->postorder_number());
- }
-
- // Print results of liveness analysis.
- void Dump();
-
- protected:
- // Compute initial values for live-out, kill and live-in sets.
- virtual void ComputeInitialSets() = 0;
-
- // Update live-out set for the given block: live-out should contain
- // all values that are live-in for block's successors.
- // Returns true if live-out set was changed.
- bool UpdateLiveOut(const BlockEntryInstr& instr);
-
- // Update live-in set for the given block: live-in should contain
- // all values that are live-out from the block and are not defined
- // by this block.
- // Returns true if live-in set was changed.
- bool UpdateLiveIn(const BlockEntryInstr& instr);
-
- // Perform fix-point iteration updating live-out and live-in sets
- // for blocks until they stop changing.
- void ComputeLiveInAndLiveOutSets();
-
- const intptr_t variable_count_;
-
- const GrowableArray<BlockEntryInstr*>& postorder_;
-
- // Live-out sets for each block. They contain indices of variables
- // that are live out from this block: that is values that were either
- // defined in this block or live into it and that are used in some
- // successor block.
- GrowableArray<BitVector*> live_out_;
-
- // Kill sets for each block. They contain indices of variables that
- // are defined by this block.
- GrowableArray<BitVector*> kill_;
-
- // Live-in sets for each block. They contain indices of variables
- // that are used by this block or its successors.
- GrowableArray<BitVector*> live_in_;
-};
-
} // namespace dart
#endif // VM_FLOW_GRAPH_H_
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698