Issue 1281973004: Make HttpClient not send fragments as part of request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1281973004: Make HttpClient not send fragments as part of request. (Closed)

Created:
5 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 4 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make HttpClient not send fragments as part of request. Make HttpServer ignore fragments sent in requests (which are invalid HTTP request syntax). Add `removeFragment` method to Uri. R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/90643a7ef7a6051701c0b97c8d3ca6ce4fde7b12

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -26 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	sdk/lib/core/uri.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	sdk/lib/io/http.dart	View	8 chunks	+9 lines, -12 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	4 chunks	+27 lines, -11 lines	0 comments	Download
M	tests/standalone/io/http_requested_uri_test.dart	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Lasse Reichstein Nielsen

5 years, 4 months ago (2015-08-10 10:18:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
90643a7ef7a6051701c0b97c8d3ca6ce4fde7b12 (presubmit successful).