Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: sdk/lib/io/http.dart

Issue 1281973004: Make HttpClient not send fragments as part of request. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/core/uri.dart ('k') | sdk/lib/io/http_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http.dart
diff --git a/sdk/lib/io/http.dart b/sdk/lib/io/http.dart
index 4bc544863c1f46e86ab9f32ede288a01163d09aa..befa0435316c909bc51c304a5393dbb123cb1cd3 100644
--- a/sdk/lib/io/http.dart
+++ b/sdk/lib/io/http.dart
@@ -958,7 +958,7 @@ abstract class HttpRequest implements Stream<List<int>> {
* The URI for the request.
*
* This provides access to the
- * path, query string, and fragment identifier for the request.
+ * path and query string for the request.
*/
Uri get uri;
@@ -1338,7 +1338,8 @@ abstract class HttpClient {
*
* The HTTP method to use is specified in [method], the server is
* specified using [host] and [port], and the path (including
- * possible fragment and query) is specified using [path].
+ * a possible query) is specified using [path].
+ * The path may also contain a URI fragment, which will be ignored.
*
* The `Host` header for the request will be set to the value
* [host]:[port]. This can be overridden through the
@@ -1377,7 +1378,7 @@ abstract class HttpClient {
* Opens a HTTP connection using the GET method.
*
* The server is specified using [host] and [port], and the path
- * (including possible fragment and query) is specified using
+ * (including a possible query) is specified using
* [path].
*
* See [open] for details.
@@ -1397,7 +1398,7 @@ abstract class HttpClient {
* Opens a HTTP connection using the POST method.
*
* The server is specified using [host] and [port], and the path
- * (including possible fragment and query) is specified using
+ * (including a possible query) is specified using
* [path].
*
* See [open] for details.
@@ -1417,8 +1418,7 @@ abstract class HttpClient {
* Opens a HTTP connection using the PUT method.
*
* The server is specified using [host] and [port], and the path
- * (including possible fragment and query) is specified using
- * [path].
+ * (including a possible query) is specified using [path].
*
* See [open] for details.
*/
@@ -1437,8 +1437,7 @@ abstract class HttpClient {
* Opens a HTTP connection using the DELETE method.
*
* The server is specified using [host] and [port], and the path
- * (including possible fragment and query) is specified using
- * [path].
+ * (including s possible query) is specified using [path].
*
* See [open] for details.
*/
@@ -1457,8 +1456,7 @@ abstract class HttpClient {
* Opens a HTTP connection using the PATCH method.
*
* The server is specified using [host] and [port], and the path
- * (including possible fragment and query) is specified using
- * [path].
+ * (including a possible query) is specified using [path].
*
* See [open] for details.
*/
@@ -1477,8 +1475,7 @@ abstract class HttpClient {
* Opens a HTTP connection using the HEAD method.
*
* The server is specified using [host] and [port], and the path
- * (including possible fragment and query) is specified using
- * [path].
+ * (including a possible query) is specified using [path].
*
* See [open] for details.
*/
« no previous file with comments | « sdk/lib/core/uri.dart ('k') | sdk/lib/io/http_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698