Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1281623002: Fix a bunch of pub tests that started running "pub get". (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a bunch of pub tests that started running "pub get". R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/b4f6d09998ae2d6681c939b665d8bbe004e2e5fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -76 lines) Patch
M test/barback/all_includes_all_default_directories_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/barback/directory_args_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/barback/subdirectories_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/converts_isolate_entrypoint_in_web_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/does_not_compile_if_disabled_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/does_not_compile_until_its_output_is_requested_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/does_not_support_invalid_command_line_options_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/does_not_support_invalid_environment_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/doesnt_support_invalid_type_for_boolean_option_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/environment_constant_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/dart2js/ignores_entrypoints_in_lib_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/ignores_non_entrypoint_dart_files_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/minifies_in_release_mode_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/minify_configuration_overrides_mode_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/output_can_be_consumed_by_successive_phases.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/passes_along_environment_constants_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/reports_dart_parse_errors_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/dart2js/source_maps_include_core_libs_in_subdirectory_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/supports_valid_options_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart2js/unminified_in_nonrelease_mode_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/global/activate/activate_path_after_hosted_test.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M test/global/activate/path_package_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M test/global/run/errors_if_outside_bin_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M test/global/run/missing_executable_arg_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M test/run/errors_if_no_executable_is_given_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M test/run/errors_if_path_in_dependency_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M test/serve/404_page_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/serve/does_not_serve_hidden_assets_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/does_not_watch_compiled_js_files_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/invalid_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/missing_asset_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/missing_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/native_watch_added_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/native_watch_modified_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/native_watch_removed_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/serve_from_app_lib_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/serve_from_app_web_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/serves_file_with_space_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/serves_index_html_for_directories_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/serves_web_and_test_dirs_by_default_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/supports_cross_origin_header_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/unknown_dependency_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/uses_appropriate_mime_types_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/watch_added_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/watch_modified_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/watch_removed_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/web_socket/exit_on_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/web_socket/path_to_urls_with_line_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/web_socket/serve_directory_already_served_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/web_socket/serve_directory_and_immediately_request_asset_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/web_socket/serve_directory_and_immediately_serve_again_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/web_socket/serve_directory_and_immediately_unserve_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/web_socket/serve_directory_arg_errors_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M test/serve/web_socket/serve_directory_overlapping_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/web_socket/serve_directory_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/web_socket/unserve_directory_arg_errors_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M test/serve/web_socket/unserve_directory_not_served_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/web_socket/unserve_directory_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/web_socket/url_to_asset_id_errors_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/serve/web_socket/url_to_asset_id_with_line_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-06 22:00:00 UTC) #1
Bob Nystrom
lgtm
5 years, 4 months ago (2015-08-06 22:03:47 UTC) #2
nweiz
5 years, 4 months ago (2015-08-06 22:49:21 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b4f6d09998ae2d6681c939b665d8bbe004e2e5fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698