Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: test/serve/web_socket/serve_directory_arg_errors_test.dart

Issue 1281623002: Fix a bunch of pub tests that started running "pub get". (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/serve/web_socket/serve_directory_arg_errors_test.dart
diff --git a/test/serve/web_socket/serve_directory_arg_errors_test.dart b/test/serve/web_socket/serve_directory_arg_errors_test.dart
index 5bd298ebe510259f8f21c755d60981d2225fb9db..458a5ade024cad48a3eb895ae0f7ce0d504a196b 100644
--- a/test/serve/web_socket/serve_directory_arg_errors_test.dart
+++ b/test/serve/web_socket/serve_directory_arg_errors_test.dart
@@ -22,7 +22,7 @@ main() {
});
integration("responds with an error if 'path' is not a string", () {
- pubServe();
+ pubServe(shouldGetFirst: true);
expectWebSocketError("serveDirectory", {"path": 123},
rpc_error_code.INVALID_PARAMS,
'Parameter "path" for method "serveDirectory" must be a string, but '
@@ -31,7 +31,7 @@ main() {
});
integration("responds with an error if 'path' is absolute", () {
- pubServe();
+ pubServe(shouldGetFirst: true);
expectWebSocketError("serveDirectory", {"path": "/absolute.txt"},
rpc_error_code.INVALID_PARAMS,
'"path" must be a relative path. Got "/absolute.txt".');
@@ -39,7 +39,7 @@ main() {
});
integration("responds with an error if 'path' reaches out", () {
- pubServe();
+ pubServe(shouldGetFirst: true);
expectWebSocketError("serveDirectory", {"path": "a/../../bad.txt"},
rpc_error_code.INVALID_PARAMS,
'"path" cannot reach out of its containing directory. Got '

Powered by Google App Engine
This is Rietveld 408576698