Avoid massive stack frames by allocating 64k buffers in the heap.

Avoid massive stack frames by allocating 64k buffers in the heap.

R=sgjesse@google.com,ajohnsen@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=20068

[siva, 2013-03-15 07:47:00]

DBC

https://codereview.chromium.org/12812006/diff/1/runtime/bin/filter.cc
File runtime/bin/filter.cc (right):

https://codereview.chromium.org/12812006/diff/1/runtime/bin/filter.cc#newcode136
runtime/bin/filter.cc:136: uint8_t* buffer = new uint8_t[kFilterBufferLength];
Not sure how frequently this function is called but it might be worthwhile
adding this buffer to the Filter object then you won't have to allocate and
delete on every call.

[Søren Gjesse, 2013-03-15 08:21:30]

lgtm - I think siva has a valid point

[Mads Ager (google), 2013-03-15 09:24:56]

PTAL. Moved the buffer to the filter. Fixed various code style issues.

https://codereview.chromium.org/12812006/diff/1/runtime/bin/filter.cc
File runtime/bin/filter.cc (right):

https://codereview.chromium.org/12812006/diff/1/runtime/bin/filter.cc#newcode136
runtime/bin/filter.cc:136: uint8_t* buffer = new uint8_t[kFilterBufferLength];
On 2013/03/15 07:47:00, siva wrote:
> Not sure how frequently this function is called but it might be worthwhile
> adding this buffer to the Filter object then you won't have to allocate and
> delete on every call.

I don't have any data on how often this is called either. But it is simple to
allocate it as part of the filter. Thanks!

[Søren Gjesse, 2013-03-15 09:45:41]

lgtm - thanks for cleaning up the codestyle.

[Mads Ager (google), 2013-03-15 10:20:09]

Committed patchset #2 manually as r20068 (presubmit successful).