Avoid massive stack frames by allocating 64k buffers in the heap.

runtime/bin/filter.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dartutils.h"
 #include "bin/filter.h"
 #include "bin/io_buffer.h"
 
 #include "include/dart_api.h"
 
@@ skipping 115 matching lines @@
 void FUNCTION_NAME(Filter_Processed)(Dart_NativeArguments args) {
   Dart_EnterScope();
   Dart_Handle filter_obj = Dart_GetNativeArgument(args, 0);
   Filter* filter = GetFilter(filter_obj);
   Dart_Handle flush_obj = Dart_GetNativeArgument(args, 1);
   bool flush;
   if (Dart_IsError(Dart_BooleanValue(flush_obj, &flush))) {
     Dart_ThrowException(DartUtils::NewInternalError(
         "Failed to get 'flush' parameter"));
   }
-  uint8_t buffer[kFilterBufferLength];
+  uint8_t* buffer = new uint8_t[kFilterBufferLength];

[siva, 2013/03/15 07:47:00]

Not sure how frequently this function is called but it might be worthwhile
adding this buffer to the Filter object then you won't have to allocate and
delete on every call.

[Mads Ager (google), 2013/03/15 09:24:56]

I don't have any data on how often this is called either. But it is simple to
allocate it as part of the filter. Thanks!

   intptr_t read = filter->Processed(buffer, kFilterBufferLength, flush);
   if (read < 0) {
     // Error, end filter.
     EndFilter(filter_obj, filter);
+    delete[] buffer;
     Dart_ThrowException(DartUtils::NewInternalError(
         "Filter error, bad data"));
   } else if (read == 0) {
     Dart_SetReturnValue(args, Dart_Null());
   } else {
     uint8_t* io_buffer;
     Dart_Handle result = IOBuffer::Allocate(read, &io_buffer);
     memmove(io_buffer, buffer, read);
     Dart_SetReturnValue(args, result);
   }
+  delete[] buffer;
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(Filter_End)(Dart_NativeArguments args) {
   Dart_EnterScope();
   Dart_Handle filter_obj = Dart_GetNativeArgument(args, 0);
   Filter* filter = GetFilter(filter_obj);
   EndFilter(filter_obj, filter);
   Dart_ExitScope();
@@ skipping 142 matching lines @@
     case Z_NEED_DICT:
     case Z_DATA_ERROR:
     case Z_STREAM_ERROR:
       // An error occoured.
       delete[] current_buffer;
       current_buffer = NULL;
       return -1;
   }
 }