Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1280713002: Replace is_synthetic bit on Fields with is_reflectable. Mark private fields of dart:* as non-reflec… (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace is_synthetic bit on Fields with is_reflectable. Mark private fields of dart:* as non-reflectable. This fixes an inconsistency in mirrors where some classes in dart:* would claim to have a field but throw NSM if one attempts to access it, and prevents accessing private static fields of dart:* that don't have implicit getters or setters. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/b34267d0d79d43bc343a26901f67a00a176f4bb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M runtime/lib/mirrors.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 5 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/object.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/object_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 6 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-06 17:10:03 UTC) #2
siva
lgtm
5 years, 4 months ago (2015-08-06 18:05:47 UTC) #3
rmacnak
5 years, 4 months ago (2015-08-06 23:48:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b34267d0d79d43bc343a26901f67a00a176f4bb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698