Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: runtime/vm/object.h

Issue 1280713002: Replace is_synthetic bit on Fields with is_reflectable. Mark private fields of dart:* as non-reflec… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 5bfc04119ebbb4238f7cc295d17ecf863aa18303..923168e879d2eb6ef088151af8fd9973f8822e16 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -2814,8 +2814,8 @@ class Field : public Object {
bool is_static() const { return StaticBit::decode(raw_ptr()->kind_bits_); }
bool is_final() const { return FinalBit::decode(raw_ptr()->kind_bits_); }
bool is_const() const { return ConstBit::decode(raw_ptr()->kind_bits_); }
- bool is_synthetic() const {
- return SyntheticBit::decode(raw_ptr()->kind_bits_);
+ bool is_reflectable() const {
+ return ReflectableBit::decode(raw_ptr()->kind_bits_);
}
inline intptr_t Offset() const;
@@ -2838,7 +2838,7 @@ class Field : public Object {
bool is_static,
bool is_final,
bool is_const,
- bool is_synthetic,
+ bool is_reflectable,
const Class& owner,
intptr_t token_pos);
@@ -2987,7 +2987,7 @@ class Field : public Object {
kFinalBit,
kHasInitializerBit,
kUnboxingCandidateBit,
- kSyntheticBit
+ kReflectableBit
};
class ConstBit : public BitField<bool, kConstBit, 1> {};
class StaticBit : public BitField<bool, kStaticBit, 1> {};
@@ -2996,7 +2996,7 @@ class Field : public Object {
class UnboxingCandidateBit : public BitField<bool,
kUnboxingCandidateBit, 1> {
};
- class SyntheticBit : public BitField<bool, kSyntheticBit, 1> {};
+ class ReflectableBit : public BitField<bool, kReflectableBit, 1> {};
// Update guarded cid and guarded length for this field. Returns true, if
// deoptimization of dependent code is required.
@@ -3012,8 +3012,8 @@ class Field : public Object {
void set_is_const(bool value) const {
set_kind_bits(ConstBit::update(value, raw_ptr()->kind_bits_));
}
- void set_is_synthetic(bool value) const {
- set_kind_bits(SyntheticBit::update(value, raw_ptr()->kind_bits_));
+ void set_is_reflectable(bool value) const {
+ set_kind_bits(ReflectableBit::update(value, raw_ptr()->kind_bits_));
}
void set_owner(const Object& value) const {
StorePointer(&raw_ptr()->owner_, value.raw());
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698