Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1280313002: remove complex keyword suggestions - fixes #23978 (Closed)

Created:
5 years, 4 months ago by danrubel
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -37 lines) Patch
M pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart View 3 chunks +2 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_contributor_test.dart View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 4 months ago (2015-08-10 12:42:36 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-10 13:51:51 UTC) #3
danrubel
5 years, 4 months ago (2015-08-10 14:09:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f79d02ddd061f4530359106a8b7232ff7a49a03b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698