remove complex keyword suggestions - fixes #23978

pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.contributor.dart.keyword;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
@@ skipping 106 matching lines @@
         // then the user is probably finishing that
         _addImportDirectiveKeywords(previousMember);
         return;
       }
     }
     if (previousMember == null || previousMember is Directive) {
       if (previousMember == null &&
           !node.directives.any((d) => d is LibraryDirective)) {
         _addSuggestions([Keyword.LIBRARY], DART_RELEVANCE_HIGH);
       }
-      _addSuggestions([Keyword.EXPORT, Keyword.PART], DART_RELEVANCE_HIGH);
-      _addSuggestion2("import '';",
-          offset: 8, relevance: DART_RELEVANCE_HIGH + 1);
-      _addSuggestion2("import '' as ;",
-          offset: 8, relevance: DART_RELEVANCE_HIGH);
-      _addSuggestion2("import '' hide ;",
-          offset: 8, relevance: DART_RELEVANCE_HIGH);
-      _addSuggestion2("import '' show ;",
-          offset: 8, relevance: DART_RELEVANCE_HIGH);
+      _addSuggestions([Keyword.IMPORT, Keyword.EXPORT, Keyword.PART], DART_RELEVANCE_HIGH);
     }
     if (entity == null || entity is Declaration) {
       if (previousMember is FunctionDeclaration &&
           previousMember.functionExpression is FunctionExpression &&
           previousMember.functionExpression.body is EmptyFunctionBody) {
         _addSuggestion2(ASYNC, relevance: DART_RELEVANCE_HIGH);
       }
       _addCompilationUnitKeywords();
     }
   }
@@ skipping 239 matching lines @@
       _addSuggestions([Keyword.SUPER, Keyword.THIS,]);
     }
     if (_inAsyncMethodOrFunction(node)) {
       _addSuggestion2(AWAIT);
     }
     _addSuggestions([
       Keyword.ASSERT,
       Keyword.CONTINUE,
       Keyword.DO,
       Keyword.FINAL,
-      //Keyword.FOR,
+      Keyword.FOR,
       Keyword.IF,
       Keyword.NEW,
       Keyword.RETURN,
       Keyword.SWITCH,
       Keyword.THROW,
       Keyword.TRY,
       Keyword.VAR,
       Keyword.VOID,
       Keyword.WHILE
     ]);
-    _addSuggestion2('for ()', offset: 5);
     _addSuggestion(Keyword.RETHROW, DART_RELEVANCE_KEYWORD - 1);
   }
 
   void _addSuggestion(Keyword keyword,
       [int relevance = DART_RELEVANCE_KEYWORD]) {
     _addSuggestion2(keyword.syntax, relevance: relevance);
   }
 
   void _addSuggestion2(String completion,
       {int offset, int relevance: DART_RELEVANCE_KEYWORD}) {
@@ skipping 24 matching lines @@
         return false;
       }
       AstNode parent = body.parent;
       if (parent is ConstructorDeclaration || parent is MethodDeclaration) {
         return true;
       }
       node = parent;
     }
   }
 }