Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1280013004: Restore frame validation (fixes to CL faaf60801f72). (Closed)

Created:
5 years, 4 months ago by koda
Modified:
5 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restore frame validation (fixes to CL faaf60801f72). BUG= R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/2ae8544e8dade1a7ca17fbf84dccb64ff0ade370

Patch Set 1 #

Patch Set 2 : Clean up test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -20 lines) Patch
M runtime/vm/isolate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_registry.h View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/thread_test.cc View 1 3 chunks +23 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 4 months ago (2015-08-11 17:56:40 UTC) #2
Ivan Posva
LGTM -ip
5 years, 4 months ago (2015-08-11 18:35:09 UTC) #3
koda
5 years, 4 months ago (2015-08-12 15:47:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2ae8544e8dade1a7ca17fbf84dccb64ff0ade370 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698