Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: runtime/vm/thread_registry.h

Issue 1280013004: Restore frame validation (fixes to CL faaf60801f72). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Clean up test. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/thread_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread_registry.h
diff --git a/runtime/vm/thread_registry.h b/runtime/vm/thread_registry.h
index b7d3e1a8a0877f2e1217c8c0925b77dc46be71be..efe81bdcfa69ca8540760424d8a289bca8943275 100644
--- a/runtime/vm/thread_registry.h
+++ b/runtime/vm/thread_registry.h
@@ -115,7 +115,8 @@ class ThreadRegistry {
}
}
- void VisitObjectPointers(ObjectPointerVisitor* visitor) {
+ void VisitObjectPointers(ObjectPointerVisitor* visitor,
+ bool validate_frames) {
MonitorLocker ml(monitor_);
for (int i = 0; i < entries_.length(); ++i) {
const Entry& entry = entries_[i];
@@ -125,9 +126,8 @@ class ThreadRegistry {
state.zone->VisitObjectPointers(visitor);
}
// Iterate over all the stack frames and visit objects on the stack.
- uword efi = state.top_exit_frame_info;
- if (efi == 0) continue;
- StackFrameIterator frames_iterator(efi, false);
+ StackFrameIterator frames_iterator(state.top_exit_frame_info,
+ validate_frames);
StackFrame* frame = frames_iterator.NextFrame();
while (frame != NULL) {
frame->VisitObjectPointers(visitor);
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/thread_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698