Use scheduled_test for Pub tests.

Use scheduled_test for Pub tests.

BUG=8511
Committed: https://code.google.com/p/dart/source/detail?r=20250

[nweiz, 2013-03-19 21:02:22]

Almost all of this is cosmetic changes. The real changes are pretty much just in
utils/pub/utils.dart and utils/pub/{test_pub.dart,descriptor.dart,descriptor}.

[Bob Nystrom, 2013-03-19 21:39:50]

Couple of suggestions/questions. Otherwise LGTM!

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/descriptor.dart
File utils/tests/pub/descriptor.dart (right):

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/descriptor.da...
utils/tests/pub/descriptor.dart:31: Descriptor get normalPackage => dir(appPath,
[
How about -> validPackage?

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/descriptor/gi...
File utils/tests/pub/descriptor/git.dart (right):

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/descriptor/gi...
utils/tests/pub/descriptor/git.dart:55: Future runGit(List<String> args, [String
parent]) => schedule(() {
"Git" seems redundant here. How about just "run" or "exec"?

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/install/git/c...
File utils/tests/pub/install/git/check_out_twice_test.dart (right):

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/install/git/c...
utils/tests/pub/install/git/check_out_twice_test.dart:42: output: new
RegExp(r"Dependencies updated!$"));
Should this test be under update?

[nweiz, 2013-03-19 21:58:10]

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/descriptor.dart
File utils/tests/pub/descriptor.dart (right):

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/descriptor.da...
utils/tests/pub/descriptor.dart:31: Descriptor get normalPackage => dir(appPath,
[
On 2013/03/19 21:39:50, Bob Nystrom wrote:
> How about -> validPackage?

Done.

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/descriptor/gi...
File utils/tests/pub/descriptor/git.dart (right):

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/descriptor/gi...
utils/tests/pub/descriptor/git.dart:55: Future runGit(List<String> args, [String
parent]) => schedule(() {
On 2013/03/19 21:39:50, Bob Nystrom wrote:
> "Git" seems redundant here. How about just "run" or "exec"?

I like that "Git" makes it read like a command-line invocation. For example,
"_runGit(['rev-parse'..." above reads like "run git rev-parse", which is what
it's doing.

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/install/git/c...
File utils/tests/pub/install/git/check_out_twice_test.dart (right):

https://codereview.chromium.org/12794007/diff/1/utils/tests/pub/install/git/c...
utils/tests/pub/install/git/check_out_twice_test.dart:42: output: new
RegExp(r"Dependencies updated!$"));
On 2013/03/19 21:39:50, Bob Nystrom wrote:
> Should this test be under update?

I don't think so; the main thrust of the test is what install does.

[nweiz, 2013-03-19 21:59:40]

Committed patchset #2 manually as r20250 (presubmit successful).