utils/tests/pub/update/hosted/fail_gracefully_on_url_resolve_test.dart - Issue 12794007: Use scheduled_test for Pub tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/tests/pub/update/hosted/fail_gracefully_on_url_resolve_test.dart

Issue 12794007: Use scheduled_test for Pub tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « utils/tests/pub/update/hosted/fail_gracefully_on_missing_package_test.dart ('k') | utils/tests/pub/update/hosted/remove_removed_dependency_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: utils/tests/pub/update/hosted/fail_gracefully_on_url_resolve_test.dart

diff --git a/utils/tests/pub/update/hosted/fail_gracefully_on_url_resolve_test.dart b/utils/tests/pub/update/hosted/fail_gracefully_on_url_resolve_test.dart

index d7f8cbd01eee6c93def1bd5a4619a3bf5795ac4f..fbf904342c34690914bd026298a6364b858b3c5e 100644

--- a/utils/tests/pub/update/hosted/fail_gracefully_on_url_resolve_test.dart

+++ b/utils/tests/pub/update/hosted/fail_gracefully_on_url_resolve_test.dart

@@ -6,12 +6,13 @@ library pub_tests;

import 'dart:io';

+import '../../descriptor.dart' as d;

import '../../test_pub.dart';

main() {

integration('fails gracefully if the url does not resolve', () {

- dir(appPath, [

- pubspec({

+ d.dir(appPath, [

+ d.pubspec({

"name": "myapp",

"dependencies": {

"foo": {

@@ -22,7 +23,7 @@ main() {

}

})

- ]).scheduleCreate();

+ ]).create();

schedulePub(args: ['update'],

error: new RegExp('Could not resolve URL "http://pub.invalid".'),