Issue 1278623002: - Make sure to close the port if a packages file was passed on the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1278623002: - Make sure to close the port if a packages file was passed on the (Closed)

Created:
5 years, 4 months ago by Ivan Posva

Modified:
5 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

- Make sure to close the port if a packages file was passed on the command line without actually loading packages. BUG=23991 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/ee9c0cbb2c86935bab2a31c241ebbbe01466e9e0

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
	M	runtime/bin/builtin.dart	View		2 chunks	+11 lines, -7 lines	0 comments	Download
	M	runtime/bin/vmservice/loader.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Ivan Posva

5 years, 4 months ago (2015-08-05 23:34:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ee9c0cbb2c86935bab2a31c241ebbbe01466e9e0 (presubmit successful).