runtime/bin/vmservice/loader.dart - Issue 1278623002: - Make sure to close the port if a packages file was passed on the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/loader.dart

Issue 1278623002: - Make sure to close the port if a packages file was passed on the (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address previous review comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice/loader.dart

diff --git a/runtime/bin/vmservice/loader.dart b/runtime/bin/vmservice/loader.dart

index 68f63d958272b9285bea93e83a29d4b825fe60ea..cd94f579ba0f39619f5de516dcb1b941d13a3d37 100644

--- a/runtime/bin/vmservice/loader.dart

+++ b/runtime/bin/vmservice/loader.dart

@@ -397,7 +397,7 @@ _handlePackagesRequest(SendPort sp,

sp.send([packageRoot.toString()]);

}

} else {

- sp.send("Unsupported base URI to identify .packages file: "

+ sp.send("Unsupported scheme used to locate .packages file: "

"'$resource'.");

}

} else if (id == -2) {

« no previous file with comments | « runtime/bin/builtin.dart ('k') | no next file » | no next file with comments »