Make allocation of Dart parameters and local variables architecture independent.

Make allocation of Dart parameters and local variables architecture independent.
Enable a couple more vm tests on ARM.
Fix function usage counter access on ARM.
Committed: https://code.google.com/p/dart/source/detail?r=20048

[zra, 2013-03-14 21:14:20]

LGTM with a comment

https://codereview.chromium.org/12776006/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/12776006/diff/1/runtime/vm/parser.cc#newcode164
runtime/vm/parser.cc:164: first_parameter_index_ = kLastParamSlotIndex +
num_params - 1;
It's a little surprising that the parser has to know something about the stack
layout.

[regis, 2013-03-14 21:32:22]

Thanks!

https://codereview.chromium.org/12776006/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/12776006/diff/1/runtime/vm/parser.cc#newcode164
runtime/vm/parser.cc:164: first_parameter_index_ = kLastParamSlotIndex +
num_params - 1;
On 2013/03/14 21:14:20, zra wrote:
> It's a little surprising that the parser has to know something about the stack
> layout.

Yes, indeed. Allocating variables was moved out of the old code generator when
the new optimizing code generator was written. This allocation is actually
fairly high level. We just assign a slot index to parameters and locals. It does
not prevent locals to be ultimately allocated in registers, for example. The
index reflects more the position of parameters and position of local variables
in their respective scopes (or contexts, if captured) than their actual memory
address or register.

[regis, 2013-03-14 21:33:14]

Committed patchset #1 manually as r20048 (presubmit successful).

[siva, 2013-03-14 21:50:33]

DBC

https://codereview.chromium.org/12776006/diff/1/runtime/vm/constants_ia32.h
File runtime/vm/constants_ia32.h (right):

https://codereview.chromium.org/12776006/diff/1/runtime/vm/constants_ia32.h#n...
runtime/vm/constants_ia32.h:79: static const int kFirstLocalSlotIndex = -2;
This file was meant for processor specific constant values but the values above
seem Dart frame layout specific constants.

Do you think stack_frame_*.h might be a better place?

[regis, 2013-03-14 21:59:41]

On 2013/03/14 21:50:33, siva wrote:
> DBC
> 
> https://codereview.chromium.org/12776006/diff/1/runtime/vm/constants_ia32.h
> File runtime/vm/constants_ia32.h (right):
> 
>
https://codereview.chromium.org/12776006/diff/1/runtime/vm/constants_ia32.h#n...
> runtime/vm/constants_ia32.h:79: static const int kFirstLocalSlotIndex = -2;
> This file was meant for processor specific constant values but the values
above
> seem Dart frame layout specific constants.
> 
> Do you think stack_frame_*.h might be a better place?

I thought of it. Yes, it would be a more proper location. However, we currently
do not have stack_frame_*.h files. We would need to replace stack_frame.h with 4
new architecture specific files.
This would allow to rewrite stack_frame.cc to be cleaner and use the
architecture dependent constants directly, rather than declare getters to fish
them from the cc files. Also, this would allow better dependency checking in the
stubs, which currently assume a lot about the layout.
This is on my list of things to do, but I always struggle between cleaning up
what we have and making progress on the port to ARM :-)