Make allocation of Dart parameters and local variables architecture independent.

runtime/vm/constants_ia32.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_CONSTANTS_IA32_H_
 #define VM_CONSTANTS_IA32_H_
 
 #include "platform/assert.h"
 
 namespace dart {
@@ skipping 55 matching lines @@
 const Register FPREG = EBP;  // Frame pointer register.
 
 // Exception object is passed in this register to the catch handlers when an
 // exception is thrown.
 const Register kExceptionObjectReg = EAX;
 
 // Stack trace object is passed in this register to the catch handlers when
 // an exception is thrown.
 const Register kStackTraceObjectReg = EDX;
 
+
+// Dart stack frame layout.
+static const int kLastParamSlotIndex = 2;
+static const int kFirstLocalSlotIndex = -2;

[siva, 2013/03/14 21:50:33]

This file was meant for processor specific constant values but the values above
seem Dart frame layout specific constants.

Do you think stack_frame_*.h might be a better place?

+
+
 enum ScaleFactor {
   TIMES_1 = 0,
   TIMES_2 = 1,
   TIMES_4 = 2,
   TIMES_8 = 3,
   TIMES_HALF_WORD_SIZE = kWordSizeLog2 - 1
 };
 
 
 enum Condition {
@@ skipping 48 matching lines @@
 };
 
 
 // The largest multibyte nop we will emit.  This could go up to 15 if it
 // becomes important to us.
 const int MAX_NOP_SIZE = 8;
 
 }  // namespace dart
 
 #endif  // VM_CONSTANTS_IA32_H_