Add support for the new analyzer to the testing scripts

Add support for the new analyzer to the testing scripts
Committed: https://code.google.com/p/dart/source/detail?r=19885

[kustermann, 2013-03-12 17:55:23]

lgtm as far as I can see.

https://codereview.chromium.org/12776004/diff/5001/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/12776004/diff/5001/tools/test.dart#newcode149
tools/test.dart:149: testSuites.add(new JUnitDartcTestSuite(conf));
Why do we add these TestSuite's in case of the old analyzer but not the new one?

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_op...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_op...
tools/testing/dart/test_options.dart:521: print(configuration['analyzer']);
Left over 'print'!

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_ru...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_ru...
tools/testing/dart/test_runner.dart:534: return new
AnalysisCommandOutputImpl(testCase,
Is the output of the new analyzer in the same format as the output of the old
analyzer?

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_ru...
tools/testing/dart/test_runner.dart:1631: test.configuration['analyzer'] &&
Indentation is strange.

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:187: return '$prefix/analyzer$suffix';
'$suffix' will probably be '.exe' on windows (and not '.bat').

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1233: args.add('--error_format');
Does the new analyzer accept the same arguments as the old one?

[ricow1, 2013-03-12 18:06:06]

Thanks for the comments

https://codereview.chromium.org/12776004/diff/5001/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/12776004/diff/5001/tools/test.dart#newcode149
tools/test.dart:149: testSuites.add(new JUnitDartcTestSuite(conf));
On 2013/03/12 17:55:23, kustermann wrote:
> Why do we add these TestSuite's in case of the old analyzer but not the new
one?
we do add them for the new one, but we actually do not need it here, I will
change below instead (this was changed with Mads change to enable library
analyzing

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_op...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_op...
tools/testing/dart/test_options.dart:521: print(configuration['analyzer']);
On 2013/03/12 17:55:23, kustermann wrote:
> Left over 'print'! 

Done.

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_ru...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_ru...
tools/testing/dart/test_runner.dart:534: return new
AnalysisCommandOutputImpl(testCase,
On 2013/03/12 17:55:23, kustermann wrote:
> Is the output of the new analyzer in the same format as the output of the old
> analyzer?

Yes

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_ru...
tools/testing/dart/test_runner.dart:1631: test.configuration['analyzer'] &&
On 2013/03/12 17:55:23, kustermann wrote:
> Indentation is strange.

Done.

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:187: return '$prefix/analyzer$suffix';
On 2013/03/12 17:55:23, kustermann wrote:
> '$suffix' will probably be '.exe' on windows (and not '.bat').

No it will actually be .bat if the file is not explicitly dart or d8

https://codereview.chromium.org/12776004/diff/5001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1233: args.add('--error_format');
On 2013/03/12 17:55:23, kustermann wrote:
> Does the new analyzer accept the same arguments as the old one?

Yes

[ricow1, 2013-03-12 18:18:33]

Committed patchset #5 manually as r19885 (presubmit successful).