Add support for the new analyzer to the testing scripts

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 512 matching lines @@
     if (testCase is BrowserTestCase) {
       return new BrowserCommandOutputImpl(testCase,
                                           command,
                                           exitCode,
                                           incomplete,
                                           timedOut,
                                           stdout,
                                           stderr,
                                           time,
                                           compilationSkipped);
-    } else if (testCase.configuration['compiler'] == 'dartc') {
+    } else if (testCase.configuration['analyzer']) {
       return new AnalysisCommandOutputImpl(testCase,

[kustermann, 2013/03/12 17:55:23]

Is the output of the new analyzer in the same format as the output of the old
analyzer?

[ricow1, 2013/03/12 18:06:06]

Yes

                                            command,
                                            exitCode,
                                            timedOut,
                                            stdout,
                                            stderr,
                                            time,
                                            compilationSkipped);
     }
     return new CommandOutputImpl(testCase,
                                  command,
@@ skipping 652 matching lines @@
         return;
       }
       // Otherwise, process output and call _reportResult() when done.
       var line = stream.readLine();
       while (line != null) {
         if (line.startsWith('>>> TEST')) {
           _status = line;
         } else if (line.startsWith('>>> BATCH')) {
           // ignore
         } else if (line.startsWith('>>> ')) {
-          throw new Exception('Unexpected command from dartc batch runner.');
+          throw new Exception(
+               'Unexpected command from ${testCase.configuration['compiler']} '
+               'batch runner.');
         } else {
           buffer.addAll(encodeUtf8(line));
           buffer.addAll("\n".charCodes);
         }
         line = stream.readLine();
       }
       if (_status != null) {
         _timer.cancel();
         _stdoutDone();
       }
@@ skipping 396 matching lines @@
       var isBrowserCommand = isLastCommand && (test is BrowserTestCase);
       if (isBrowserCommand && _numBrowserProcesses == _maxBrowserProcesses) {
         // If there is no free browser runner, put it back into the queue.
         _tests.add(test);
         new Timer(100, (_) => _tryRunTest());  // Don't lose a process.
         return;
       }
 
       _progress.start(test);
 
-      // Dartc and browser test commands can be run by a [BatchRunnerProcess]
+      // Analyzer and browser test commands can be run by a [BatchRunnerProcess]
       var nextCommandIndex = test.commandOutputs.keys.length;
       var numberOfCommands = test.commands.length;
-      var useBatchRunnerForDartc = test.configuration['compiler'] == 'dartc' &&
-                                   test.displayName != 'dartc/junit_tests';
+        
+      var useBatchRunnerForAnalyzer = 
+        test.configuration['analyzer'] &&

[kustermann, 2013/03/12 17:55:23]

Indentation is strange.

[ricow1, 2013/03/12 18:06:06]

Done.

+        test.displayName != 'dartc/junit_tests';
       var isWebdriverCommand = nextCommandIndex == (numberOfCommands - 1) &&
                                test.usesWebDriver &&
                                !test.configuration['noBatch'];
-      if (useBatchRunnerForDartc || isWebdriverCommand) {
+      if (useBatchRunnerForAnalyzer || isWebdriverCommand) {
         TestCaseEvent oldCallback = test.completedHandler;
         void testCompleted(TestCase test_arg) {
           _numProcesses--;
           if (isBrowserCommand) {
             _numBrowserProcesses--;
           }
           _progress.done(test_arg);
           if (test_arg is BrowserTestCase) test_arg.notifyObservers();
           oldCallback(test_arg);
           _tryRunTest();
@@ skipping 103 matching lines @@
           completer.complete(testCase);
         }
       });
     }
     runCommand();
 
     return completer.future;
   }
 }