Chromium Code Reviews Chromium Code Reviews
Issue
1277473004:
Safe and efficient stack-limit based interrupt checking in C++. (Closed)
DescriptionSafe and efficient stack-limit based interrupt checking in C++.
Remove potentially dangerous (but currently unused) Isolate::stack_limit() accessor.
Add method to test whether interrupts are scheduled, using relaxed memory ordering.
Document and test correct usage by adding a new unit test.
This will be used to periodically check for safepoints in C++ (which will then be equivalent to our generated code).
BUG=
R=iposva@google.com
Committed: https://github.com/dart-lang/sdk/commit/086329fd9c6901ae70ca4819ff9641e34329741b
Patch Set 1 #Patch Set 2 : More general interfaces; comment. #Patch Set 3 : Comments. #
Total comments: 2
Patch Set 4 : Mac and android. #Patch Set 5 : Add unit test. #Patch Set 6 : Actually add the unit test. #Patch Set 7 : More comments in test. #Patch Set 8 : Explicitly signal task ready. #
Messages
Total messages: 9 (2 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
