Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: runtime/vm/atomic_win.h

Issue 1277473004: Safe and efficient stack-limit based interrupt checking in C++. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/atomic_linux.h ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ATOMIC_WIN_H_ 5 #ifndef VM_ATOMIC_WIN_H_
6 #define VM_ATOMIC_WIN_H_ 6 #define VM_ATOMIC_WIN_H_
7 7
8 #if !defined VM_ATOMIC_H_ 8 #if !defined VM_ATOMIC_H_
9 #error Do not include atomic_win.h directly. Use atomic.h instead. 9 #error Do not include atomic_win.h directly. Use atomic.h instead.
10 #endif 10 #endif
(...skipping 10 matching lines...) Expand all
21 InterlockedIncrement64(reinterpret_cast<LONGLONG*>(p))) - 1; 21 InterlockedIncrement64(reinterpret_cast<LONGLONG*>(p))) - 1;
22 #elif defined(TARGET_ARCH_IA32) 22 #elif defined(TARGET_ARCH_IA32)
23 return static_cast<uintptr_t>( 23 return static_cast<uintptr_t>(
24 InterlockedIncrement(reinterpret_cast<LONG*>(p))) - 1; 24 InterlockedIncrement(reinterpret_cast<LONG*>(p))) - 1;
25 #else 25 #else
26 UNIMPLEMENTED(); 26 UNIMPLEMENTED();
27 #endif 27 #endif
28 } 28 }
29 29
30 30
31 inline intptr_t AtomicOperations::FetchAndAdd(intptr_t* p, intptr_t delta) {
32 #if defined(TARGET_ARCH_X64)
33 return static_cast<intptr_t>(
34 InterlockedAdd64(reinterpret_cast<LONGLONG*>(p), delta)) - 1;
Ivan Posva 2015/08/07 20:55:46 What does the -1 mean here?
koda 2015/08/07 21:05:22 Fixed to 'delta' (InterlockedAdd returns the value
35 #elif defined(TARGET_ARCH_IA32)
36 return static_cast<intptr_t>(
37 InterlockedAdd(reinterpret_cast<LONG*>(p), delta)) - 1;
38 #else
39 UNIMPLEMENTED();
40 #endif
41 }
42
43
31 #if !defined(USING_SIMULATOR) 44 #if !defined(USING_SIMULATOR)
32 inline uword AtomicOperations::CompareAndSwapWord(uword* ptr, 45 inline uword AtomicOperations::CompareAndSwapWord(uword* ptr,
33 uword old_value, 46 uword old_value,
34 uword new_value) { 47 uword new_value) {
35 #if defined(TARGET_ARCH_X64) 48 #if defined(TARGET_ARCH_X64)
36 return static_cast<uword>( 49 return static_cast<uword>(
37 InterlockedCompareExchange64(reinterpret_cast<LONGLONG*>(ptr), 50 InterlockedCompareExchange64(reinterpret_cast<LONGLONG*>(ptr),
38 static_cast<LONGLONG>(new_value), 51 static_cast<LONGLONG>(new_value),
39 static_cast<LONGLONG>(old_value))); 52 static_cast<LONGLONG>(old_value)));
40 #elif defined(TARGET_ARCH_IA32) 53 #elif defined(TARGET_ARCH_IA32)
41 return static_cast<uword>( 54 return static_cast<uword>(
42 InterlockedCompareExchange(reinterpret_cast<LONG*>(ptr), 55 InterlockedCompareExchange(reinterpret_cast<LONG*>(ptr),
43 static_cast<LONG>(new_value), 56 static_cast<LONG>(new_value),
44 static_cast<LONG>(old_value))); 57 static_cast<LONG>(old_value)));
45 #else 58 #else
46 UNIMPLEMENTED(); 59 UNIMPLEMENTED();
47 #endif 60 #endif
48 } 61 }
49 #endif // !defined(USING_SIMULATOR) 62 #endif // !defined(USING_SIMULATOR)
50 63
64
65 inline uword AtomicOperations::LoadRelaxed(uword* ptr) {
66 // TODO(koda): Consider using C++11 <atomic> to avoid the barrier on more
67 // compilers/platforms.
68 return FetchAndAdd(reinterpret_cast<intptr_t*>(ptr), 0);
69 }
70
51 } // namespace dart 71 } // namespace dart
52 72
53 #endif // VM_ATOMIC_WIN_H_ 73 #endif // VM_ATOMIC_WIN_H_
OLDNEW
« no previous file with comments | « runtime/vm/atomic_linux.h ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698