Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 12741004: Accommodate a race condition in pkg/scheduled_test/scheduled_process_test. (Closed)

Created:
7 years, 9 months ago by nweiz
Modified:
7 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Accommodate a race condition in pkg/scheduled_test/scheduled_process_test. BUG=9022 Committed: https://code.google.com/p/dart/source/detail?r=19754

Patch Set 1 #

Patch Set 2 : Remove a bad timeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -96 lines) Patch
M pkg/scheduled_test/lib/scheduled_process.dart View 5 chunks +15 lines, -15 lines 0 comments Download
M pkg/scheduled_test/lib/src/utils.dart View 1 chunk +14 lines, -7 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_process_test.dart View 1 4 chunks +85 lines, -74 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 9 months ago (2013-03-09 01:20:34 UTC) #1
Jennifer Messerly
lgtm! very cool that you tracked that down :)
7 years, 9 months ago (2013-03-09 01:49:21 UTC) #2
nweiz
7 years, 9 months ago (2013-03-09 02:02:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19754 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698