Accommodate a race condition in pkg/scheduled_test/scheduled_process_test.

pkg/scheduled_test/test/scheduled_process_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library scheduled_process_test;
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:pathos/path.dart' as path;
@@ skipping 100 matching lines @@
   });
 
   expectTestsPass("shouldExit can't be called after kill", () {
     test('test', () {
       var process = startDartProcess('');
       process.kill();
       expect(() => process.shouldExit(0), throwsA(isStateError));
     });
   });
 
-  // TODO(nweiz): re-enable this (issue 9022).
-  // expectTestsPass("a process that ends while waiting for stdout shouldn't "
-  //     "block the test", () {
-  //   var errors;
-  //   test('test 1', () {
-  //     currentSchedule.onException.schedule(() {
-  //       errors = currentSchedule.errors;
-  //     });
-  //
-  //     var process = startDartProcess('');
-  //     expect(process.nextLine(), completion(equals('hello')));
-  //     expect(process.nextLine(), completion(equals('world')));
-  //     process.shouldExit(0);
-  //   });
-  //
-  //   test('test 2', () {
-  //     expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
-  //     expect(errors.length, equals(2));
-  //     expect(errors[0].error, isStateError);
-  //     expect(errors[0].error.message, equals("No elements"));
-  //     expect(errors[1].error, matches(r"^Process "
-  //         r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
-  //         r"exit code 0\."));
-  //   });
-  // }, passing: ['test 2']);
+  expectTestsPass("a process that ends while waiting for stdout shouldn't "
+      "block the test", () {
+    var errors;
+    test('test 1', () {
+      currentSchedule.onException.schedule(() {
+        errors = currentSchedule.errors;
+      });
+  
+      var process = startDartProcess('');
+      expect(process.nextLine(), completion(equals('hello')));
+      expect(process.nextLine(), completion(equals('world')));
+      process.shouldExit(0);
+    });
+  
+    test('test 2', () {
+      expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
+      expect(errors.length, anyOf(1, 2));
+      expect(errors[0].error, isStateError);
+      expect(errors[0].error.message, equals("No elements"));
+
+      // Whether or not this error appears depends on how quickly the "no
+      // elements" error is handled.
+      if (errors.length == 2) {
+        expect(errors[1].error, matches(r"^Process "
+            r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
+            r"exit code 0\."));
+      }
+    });
+  }, passing: ['test 2']);
 
   expectTestsPass("a process that ends during the task immediately before it's "
       "scheduled to end shouldn't cause an error", () {
     test('test', () {
       var process = startDartProcess('stdin.toList();');
       process.closeStdin();
       // Unfortunately, sleeping for a second seems like the best way of
       // guaranteeing that the process ends during this task.
       schedule(() => new Future.delayed(new Duration(seconds: 1)));
       process.shouldExit(0);
     });
   });
 
   expectTestsPass("nextLine returns the next line of stdout from the process",
       () {
     test('test', () {
       var process = startDartProcess(r'print("hello\n\nworld"); print("hi");');
       expect(process.nextLine(), completion(equals('hello')));
       expect(process.nextLine(), completion(equals('')));
       expect(process.nextLine(), completion(equals('world')));
       expect(process.nextLine(), completion(equals('hi')));
       process.shouldExit(0);
     });
   });
 
-  // TODO(nweiz): re-enable this (issue 9022).
-  // expectTestsPass("nextLine throws an error if there's no more stdout", () {
-  //   var errors;
-  //   test('test 1', () {
-  //     currentSchedule.onException.schedule(() {
-  //       errors = currentSchedule.errors;
-  //     });
-  //
-  //     var process = startDartProcess('print("hello");');
-  //     expect(process.nextLine(), completion(equals('hello')));
-  //     expect(process.nextLine(), completion(equals('world')));
-  //     process.shouldExit(0);
-  //   });
-  //
-  //   test('test 2', () {
-  //     expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
-  //     expect(errors.length, equals(2));
-  //     expect(errors[0].error, isStateError);
-  //     expect(errors[0].error.message, equals("No elements"));
-  //     expect(errors[1].error, matches(r"^Process "
-  //         r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
-  //         r"exit code 0\."));
-  //   });
-  // }, passing: ['test 2']);
+  expectTestsPass("nextLine throws an error if there's no more stdout", () {
+    var errors;
+    test('test 1', () {
+      currentSchedule.onException.schedule(() {
+        errors = currentSchedule.errors;
+      });
+  
+      var process = startDartProcess('print("hello");');
+      expect(process.nextLine(), completion(equals('hello')));
+      expect(process.nextLine(), completion(equals('world')));
+      process.shouldExit(0);
+    });
+  
+    test('test 2', () {
+      expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
+      expect(errors.length, anyOf(1, 2));
+      expect(errors[0].error, isStateError);
+      expect(errors[0].error.message, equals("No elements"));
+
+      // Whether or not this error appears depends on how quickly the "no
+      // elements" error is handled.
+      if (errors.length == 2) {
+        expect(errors[1].error, matches(r"^Process "
+            r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
+            r"exit code 0\."));
+      }
+    });
+  }, passing: ['test 2']);
 
   expectTestsPass("nextErrLine returns the next line of stderr from the "
       "process", () {
     test('test', () {
       var process = startDartProcess(r'''
           stderr.write("hello\n\nworld\n");
           stderr.write("hi");
           ''');
       expect(process.nextErrLine(), completion(equals('hello')));
       expect(process.nextErrLine(), completion(equals('')));
       expect(process.nextErrLine(), completion(equals('world')));
       expect(process.nextErrLine(), completion(equals('hi')));
       process.shouldExit(0);
     });
   });
 
-  // TODO(nweiz): re-enable this (issue 9022).
-  // expectTestsPass("nextErrLine throws an error if there's no more stderr", () {
-  //   var errors;
-  //   test('test 1', () {
-  //     currentSchedule.onException.schedule(() {
-  //       errors = currentSchedule.errors;
-  //     });
-  //
-  //     var process = startDartProcess(r'stderr.write("hello\n");');
-  //     expect(process.nextErrLine(), completion(equals('hello')));
-  //     expect(process.nextErrLine(), completion(equals('world')));
-  //     process.shouldExit(0);
-  //   });
-  //
-  //   test('test 2', () {
-  //     expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
-  //     expect(errors.length, equals(2));
-  //     expect(errors[0].error, isStateError);
-  //     expect(errors[0].error.message, equals("No elements"));
-  //     expect(errors[1].error, matches(r"^Process "
-  //         r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
-  //         r"exit code 0\."));
-  //   });
-  // }, passing: ['test 2']);
+  expectTestsPass("nextErrLine throws an error if there's no more stderr", () {
+    var errors;
+    test('test 1', () {
+      currentSchedule.onException.schedule(() {
+        errors = currentSchedule.errors;
+      });
+  
+      var process = startDartProcess(r'stderr.write("hello\n");');
+      expect(process.nextErrLine(), completion(equals('hello')));
+      expect(process.nextErrLine(), completion(equals('world')));
+      process.shouldExit(0);
+    });
+  
+    test('test 2', () {
+      expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
+      expect(errors.length, anyOf(1, 2));
+      expect(errors[0].error, isStateError);
+      expect(errors[0].error.message, equals("No elements"));
+
+      // Whether or not this error appears depends on how quickly the "no
+      // elements" error is handled.
+      if (errors.length == 2) {
+        expect(errors[1].error, matches(r"^Process "
+            r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
+            r"exit code 0\."));
+      }
+    });
+  }, passing: ['test 2']);
 
   expectTestsPass("remainingStdout returns all the stdout if it's not consumed "
       "any other way", () {
     test('test', () {
       var process = startDartProcess(r'print("hello\n\nworld"); print("hi");');
       process.shouldExit(0);
       expect(process.remainingStdout(),
           completion(equals("hello\n\nworld\nhi")));
     });
   });
@@ skipping 81 matching lines @@
       process.writeLine("hello");
       expect(process.nextLine(), completion(equals("> hello")));
       process.writeLine("world");
       expect(process.nextLine(), completion(equals("> world")));
       process.kill();
     });
   });
 
   expectTestsPass("closeStdin closes the process's stdin stream", () {
     test('test', () {
-      currentSchedule.timeout = new Duration(seconds: 1);
       var process = startDartProcess(r'''
           stdin.listen((line) => print("> $line"),
               onDone: () => print("stdin closed"));
           ''');
       process.closeStdin();
       process.shouldExit(0);
       expect(process.nextLine(), completion(equals('stdin closed')));
     });
   });
 }
@@ skipping 24 matching lines @@
 
   currentSchedule.onComplete.schedule(() {
     return tempDir.catchError((_) => null).then((dir) {
       if (dir == null) return;
       return new Directory(dir).delete(recursive: true);
     });
   }, 'clean up temp dir');
 
   return new ScheduledProcess.start(dartExecutable, ['--checked', dartPath]);
 }