Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1274073003: Refactor visitSendSet for super compounds and assignment. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor visitSendSet for super compounds and assignment. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/29cdb17f39f80e8da1f6611b1f025857d8c04b99

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use bug number for TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -60 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 31 chunks +225 lines, -43 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 3 chunks +24 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 5 chunks +16 lines, -6 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-06 09:12:07 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1274073003/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1274073003/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode2997 pkg/compiler/lib/src/resolution/members.dart:2997: // TODO(johnniwinther): Remove these when elements are only ...
5 years, 4 months ago (2015-08-06 11:27:17 UTC) #3
Johnni Winther
https://codereview.chromium.org/1274073003/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1274073003/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode2997 pkg/compiler/lib/src/resolution/members.dart:2997: // TODO(johnniwinther): Remove these when elements are only accessed ...
5 years, 4 months ago (2015-08-06 12:26:52 UTC) #4
Johnni Winther
5 years, 4 months ago (2015-08-06 12:38:12 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
29cdb17f39f80e8da1f6611b1f025857d8c04b99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698