Refactor visitSendSet for super compounds and assignment.

tests/compiler/dart2js/semantic_visitor_test_send_data.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.semantics_visitor_test;
 
 const Map<String, List<Test>> SEND_TESTS = const {
   'Parameters': const [
     // Parameters
     const Test('m(o) => o;',
@@ skipping 1173 matching lines @@
         class B {
           var o;
         }
         class C extends B {
           m() { super.o = 42; }
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_FIELD_SET,
                     element: 'field(B#o)',
                     rhs: '42')),
-    // TODO(johnniwinther): Expect [VISIT_FINAL_SUPER_FIELD_SET] instead.
     const Test.clazz(
         '''
         class B {
           final o = 0;
         }
         class C extends B {
           m() { super.o = 42; }
         }
         ''',
-        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
-                    name: 'o',
+        const Visit(VisitKind.VISIT_FINAL_SUPER_FIELD_SET,
+                    element: 'field(B#o)',
                     rhs: '42')),
     const Test.clazz(
         '''
         class B {
           var o;
         }
         class C extends B {
           m() { super.o(null, 42); }
         }
         ''',
@@ skipping 27 matching lines @@
         '''
         class B {
           set o(_) {}
         }
         class C extends B {
           m() => super.o;
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_SETTER_GET,
                     element: 'setter(B#o)')),
-    // TODO(johnniwinther): Expect [VISIT_SUPER_GETTER_SET] instead.
     const Test.clazz(
         '''
         class B {
           get o => 0;
         }
         class C extends B {
           m() { super.o = 42; }
         }
         ''',
-        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
-                    name: 'o',
+        const Visit(VisitKind.VISIT_SUPER_GETTER_SET,
+                    element: 'getter(B#o)',
                     rhs: '42')),
     const Test.clazz(
         '''
         class B {
           set o(_) {}
         }
         class C extends B {
           m() { super.o = 42; }
         }
         ''',
@@ skipping 37 matching lines @@
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_METHOD_GET,
                     element: 'function(B#o)')),
     const Test.clazz(
         '''
         class B {
           o(a, b) {}
         }
         class C extends B {
+          m() { super.o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_SUPER_METHOD_SET,
+                    element: 'function(B#o)',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class B {
+          o(a, b) {}
+        }
+        class C extends B {
           m() { super.o(null, 42); }
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_METHOD_INVOKE,
                     element: 'function(B#o)',
                     arguments: '(null,42)')),
     const Test.clazz(
         '''
         class B {
           o(a, b) {}
@@ skipping 2467 matching lines @@
         '''
         m(a) => a ??= 42;
         ''',
         const Visit(
             VisitKind.VISIT_PARAMETER_COMPOUND,
             element: 'parameter(m#a)',
             operator: '??=',
             rhs: '42')),
   ],
 };