Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 12726011: Enables cross-compilation of the VM for ARM. (Closed)

Created:
7 years, 9 months ago by zra
Modified:
7 years, 8 months ago
Reviewers:
ricow1, ahe, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enables cross-compilation of the VM for ARM. Uses the "toolset" feature of gyp to build the dart VM for ARM, but restricts building of snapshot generation to the host machine. For generated source files, it also changes to using LIB_DIR instead of SHARED_INTERMEDIATE_DIR to avoid generation of duplicate Makefile rules (gyp doesn't know that generated source files from toolchains it thinks are different will be the same.) Committed: https://code.google.com/p/dart/source/detail?r=21757

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Total comments: 4

Patch Set 7 : #

Patch Set 8 : #

Total comments: 2

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -71 lines) Patch
M runtime/bin/bin.gypi View 1 2 3 4 5 6 7 8 9 10 chunks +30 lines, -10 lines 0 comments Download
M runtime/dart-runtime.gyp View 1 2 3 4 5 6 7 8 9 4 chunks +5 lines, -1 line 0 comments Download
M runtime/platform/globals.h View 1 2 3 4 5 6 7 8 9 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/third_party/double-conversion/src/double-conversion.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M runtime/third_party/jscre/jscre.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -13 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/vm.gypi View 1 2 3 4 5 6 7 8 9 26 chunks +60 lines, -34 lines 0 comments Download
M tools/build.py View 1 2 3 4 5 6 7 8 9 3 chunks +26 lines, -7 lines 0 comments Download
M tools/gyp/configurations_make.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ricow1
https://codereview.chromium.org/12726011/diff/20001/tools/build.py File tools/build.py (right): https://codereview.chromium.org/12726011/diff/20001/tools/build.py#newcode109 tools/build.py:109: toolchainprefix = armcompilerlocation + "/bin/arm-none-linux-gnueabi" I suggest changing armcompilerlocation ...
7 years, 8 months ago (2013-04-09 09:23:06 UTC) #1
zra
https://codereview.chromium.org/12726011/diff/20001/tools/build.py File tools/build.py (right): https://codereview.chromium.org/12726011/diff/20001/tools/build.py#newcode109 tools/build.py:109: toolchainprefix = armcompilerlocation + "/bin/arm-none-linux-gnueabi" On 2013/04/09 09:23:06, ricow1 ...
7 years, 8 months ago (2013-04-10 19:04:49 UTC) #2
ricow1
https://codereview.chromium.org/12726011/diff/20001/tools/build.py File tools/build.py (right): https://codereview.chromium.org/12726011/diff/20001/tools/build.py#newcode109 tools/build.py:109: toolchainprefix = armcompilerlocation + "/bin/arm-none-linux-gnueabi" On 2013/04/09 09:23:06, ricow1 ...
7 years, 8 months ago (2013-04-15 11:39:44 UTC) #3
kustermann
https://codereview.chromium.org/12726011/diff/28001/runtime/bin/bin.gypi File runtime/bin/bin.gypi (right): https://codereview.chromium.org/12726011/diff/28001/runtime/bin/bin.gypi#newcode15 runtime/bin/bin.gypi:15: 'resources_cc_file': '<(SHARED_INTERMEDIATE_DIR)/resources_gen.cc', Is it correct that 'snapshot_cc_file' and 'resources_cc_file' ...
7 years, 8 months ago (2013-04-15 11:59:21 UTC) #4
zra
Thanks! https://codereview.chromium.org/12726011/diff/20001/tools/build.py File tools/build.py (right): https://codereview.chromium.org/12726011/diff/20001/tools/build.py#newcode109 tools/build.py:109: toolchainprefix = armcompilerlocation + "/bin/arm-none-linux-gnueabi" On 2013/04/15 11:39:44, ...
7 years, 8 months ago (2013-04-15 17:52:58 UTC) #5
kustermann
lgtm You could let peter take a look as well, before you commit.
7 years, 8 months ago (2013-04-15 18:18:47 UTC) #6
ahe
https://codereview.chromium.org/12726011/diff/42001/runtime/bin/bin.gypi File runtime/bin/bin.gypi (right): https://codereview.chromium.org/12726011/diff/42001/runtime/bin/bin.gypi#newcode7 runtime/bin/bin.gypi:7: 'gen_source_dir': '<(LIB_DIR)', Why are the sources going in LIB_DIR?
7 years, 8 months ago (2013-04-15 18:30:40 UTC) #7
zra
https://codereview.chromium.org/12726011/diff/42001/runtime/bin/bin.gypi File runtime/bin/bin.gypi (right): https://codereview.chromium.org/12726011/diff/42001/runtime/bin/bin.gypi#newcode7 runtime/bin/bin.gypi:7: 'gen_source_dir': '<(LIB_DIR)', On 2013/04/15 18:30:40, ahe wrote: > Why ...
7 years, 8 months ago (2013-04-15 18:47:00 UTC) #8
kustermann
Since nobody has complained so far and this CL is now a month old, I ...
7 years, 8 months ago (2013-04-19 16:40:33 UTC) #9
zra
7 years, 8 months ago (2013-04-19 18:05:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #10 manually as r21757 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698