Enables cross-compilation of the VM for ARM.

Enables cross-compilation of the VM for ARM.

Uses the "toolset" feature of gyp to build the dart VM
for ARM, but restricts building of snapshot generation
to the host machine.

For generated source files, it also changes to using
LIB_DIR instead of SHARED_INTERMEDIATE_DIR to avoid
generation of duplicate Makefile rules (gyp doesn't
know that generated source files from toolchains it
thinks are different will be the same.)

Committed: https://code.google.com/p/dart/source/detail?r=21757

[ricow1, 2013-04-09 09:23:06]

https://codereview.chromium.org/12726011/diff/20001/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/12726011/diff/20001/tools/build.py#newcode109
tools/build.py:109: toolchainprefix = armcompilerlocation +
"/bin/arm-none-linux-gnueabi"
I suggest changing armcompilerlocation to  DEFAULT_ARM_CROSS_COMPILER_PATH at
the top of this file and changing it back to the gnu compiler (again, sorry for
confusion).
Additionally, I would add a comment above saying:
To make sure that you have arm cross compilation tools installed run:
wget http://src.chromium.org/chrome/trunk/src/build/install-build-deps.sh
./install-build-deps.sh --arm
(also add this to wiki)

[zra, 2013-04-10 19:04:49]

https://codereview.chromium.org/12726011/diff/20001/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/12726011/diff/20001/tools/build.py#newcode109
tools/build.py:109: toolchainprefix = armcompilerlocation +
"/bin/arm-none-linux-gnueabi"
On 2013/04/09 09:23:06, ricow1 wrote:
> I suggest changing armcompilerlocation to  DEFAULT_ARM_CROSS_COMPILER_PATH at
> the top of this file and changing it back to the gnu compiler (again, sorry
for
> confusion).
> Additionally, I would add a comment above saying:
> To make sure that you have arm cross compilation tools installed run:
> wget http://src.chromium.org/chrome/trunk/src/build/install-build-deps.sh
> ./install-build-deps.sh --arm
> (also add this to wiki)

Done. I also updated the "Preparing Your Machine" section of the wiki to mention
the --arm flag to install-build-deps.sh.

[ricow1, 2013-04-15 11:39:44]

https://codereview.chromium.org/12726011/diff/20001/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/12726011/diff/20001/tools/build.py#newcode109
tools/build.py:109: toolchainprefix = armcompilerlocation +
"/bin/arm-none-linux-gnueabi"
On 2013/04/09 09:23:06, ricow1 wrote:
> I suggest changing armcompilerlocation to  DEFAULT_ARM_CROSS_COMPILER_PATH at
> the top of this file and changing it back to the gnu compiler (again, sorry
for
> confusion).
> Additionally, I would add a comment above saying:
> To make sure that you have arm cross compilation tools installed run:
> wget http://src.chromium.org/chrome/trunk/src/build/install-build-deps.sh
> ./install-build-deps.sh --arm
> (also add this to wiki)
Alternatively, and even better, could we show an error if you try and the cross
compiler is not there (specifying how to get them installed as stated above?

[kustermann, 2013-04-15 11:59:21]

https://codereview.chromium.org/12726011/diff/28001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/12726011/diff/28001/runtime/bin/bin.gypi#newc...
runtime/bin/bin.gypi:15: 'resources_cc_file':
'<(SHARED_INTERMEDIATE_DIR)/resources_gen.cc',
Is it correct that 'snapshot_cc_file' and 'resources_cc_file' are completely
target independent?

https://codereview.chromium.org/12726011/diff/28001/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/12726011/diff/28001/tools/build.py#newcode24
tools/build.py:24: # $ ./install-build-deps.sh --arm
This doesn't quite work (at least on my machine). Replace it by:
$ svn co http://src.chromium.org/chrome/trunk/src/build
$ cd build; ./install-build-deps.sh --arm

[zra, 2013-04-15 17:52:58]

Thanks!

https://codereview.chromium.org/12726011/diff/20001/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/12726011/diff/20001/tools/build.py#newcode109
tools/build.py:109: toolchainprefix = armcompilerlocation +
"/bin/arm-none-linux-gnueabi"
On 2013/04/15 11:39:44, ricow1 wrote:
> On 2013/04/09 09:23:06, ricow1 wrote:
> > I suggest changing armcompilerlocation to  DEFAULT_ARM_CROSS_COMPILER_PATH
at
> > the top of this file and changing it back to the gnu compiler (again, sorry
> for
> > confusion).
> > Additionally, I would add a comment above saying:
> > To make sure that you have arm cross compilation tools installed run:
> > wget http://src.chromium.org/chrome/trunk/src/build/install-build-deps.sh
> > ./install-build-deps.sh --arm
> > (also add this to wiki)
> Alternatively, and even better, could we show an error if you try and the
cross
> compiler is not there (specifying how to get them installed as stated above?

Done.

https://codereview.chromium.org/12726011/diff/28001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/12726011/diff/28001/runtime/bin/bin.gypi#newc...
runtime/bin/bin.gypi:15: 'resources_cc_file':
'<(SHARED_INTERMEDIATE_DIR)/resources_gen.cc',
On 2013/04/15 11:59:22, kustermann wrote:
> Is it correct that 'snapshot_cc_file' and 'resources_cc_file' are completely
> target independent?

They are both architecture independent. Additionally, the binary that generates
the snapshot_cc_file is only built for the host. In order to be picked up by the
dart binary for the target, it has to be in a shared location. I've added a
comment explaining this. There's no need for the resources_cc_file to be in a
shared location, though, so I've changed it to get_source_dir. This is probably
more clear. The only downside is that resources_cc_file is needlessly generated
twice.

https://codereview.chromium.org/12726011/diff/28001/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/12726011/diff/28001/tools/build.py#newcode24
tools/build.py:24: # $ ./install-build-deps.sh --arm
On 2013/04/15 11:59:22, kustermann wrote:
> This doesn't quite work (at least on my machine). Replace it by:
> $ svn co http://src.chromium.org/chrome/trunk/src/build
> $ cd build; ./install-build-deps.sh --arm

Was the problem that './linux/install-chromeos-fonts.py' isn't found? Passing
--no-chromeos-fonts fixes that, but I've also included the svn command to get
all the chrome build files, just in case. I've updated the instructions here and
on the wiki. I also updated both places to suggest doing a chmod u+x of the
script instead of sourcing it, so that when the script calls exit it doesn't
close the terminal.

[kustermann, 2013-04-15 18:18:47]

lgtm

You could let peter take a look as well, before you commit.

[ahe, 2013-04-15 18:30:40]

https://codereview.chromium.org/12726011/diff/42001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/12726011/diff/42001/runtime/bin/bin.gypi#newc...
runtime/bin/bin.gypi:7: 'gen_source_dir': '<(LIB_DIR)',
Why are the sources going in LIB_DIR?

[zra, 2013-04-15 18:47:00]

https://codereview.chromium.org/12726011/diff/42001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/12726011/diff/42001/runtime/bin/bin.gypi#newc...
runtime/bin/bin.gypi:7: 'gen_source_dir': '<(LIB_DIR)',
On 2013/04/15 18:30:40, ahe wrote:
> Why are the sources going in LIB_DIR?

SHARED_INTERMEDIATE_DIR isn't toolset specific, whereas LIB_DIR is. I've added a
comment here explaining this.

[kustermann, 2013-04-19 16:40:33]

Since nobody has complained so far and this CL is now a month old, I think you
could try landing it.

We got an ARM board (with a buildbot slave on it) in the meantime and can push
things forward now.

[zra, 2013-04-19 18:05:54]

Committed patchset #10 manually as r21757 (presubmit successful).