Issue 1272223002: VM: Simplify assembler test by removing unused parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1272223002: VM: Simplify assembler test by removing unused parameter. (Closed)

Created:
5 years, 4 months ago by Florian Schneider

Modified:
5 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Simplify assembler test by removing unused parameter. No need to pass a Context into assembler tests. BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/28c5ba6bdc6cbe2c6bc35645b6bf455eb51bb03d

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -64 lines)			Patch
M	runtime/vm/assembler_arm64_test.cc	View	1 chunk	+7 lines, -11 lines	0 comments	Download
M	runtime/vm/assembler_arm_test.cc	View	1 chunk	+9 lines, -11 lines	0 comments	Download
M	runtime/vm/assembler_ia32_test.cc	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/assembler_mips_test.cc	View	1 chunk	+11 lines, -15 lines	0 comments	Download
M	runtime/vm/assembler_test.cc	View	3 chunks	+9 lines, -11 lines	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	runtime/vm/simulator_arm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/simulator_arm64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/simulator_mips.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Florian Schneider

5 years, 4 months ago (2015-08-06 08:24:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
28c5ba6bdc6cbe2c6bc35645b6bf455eb51bb03d (presubmit successful).