Fix typo.

This fixes a typo.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/5e2dbbbba42c011a54d5716ff6cd27b1f4a6e2b4

[regis, 2015-08-04 23:04:18]

regis@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-08-04 23:17:29]

lgtm

[regis, 2015-08-04 23:23:08]

On 2015/08/04 23:17:29, siva wrote:
> lgtm

Git refuses to commit my change:

$ git cl land
Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit commit checks ...
Done processing
/usr/local/google/home/regis/ssd/dart4/sdk/runtime/vm/class_table.h

Presubmit checks passed.
No description set.
Visit None/edit to set it.


Is it confused by the fact that the description starts with "Fix"?

[regis, 2015-08-04 23:33:39]

On 2015/08/04 23:23:08, regis wrote:
> On 2015/08/04 23:17:29, siva wrote:
> > lgtm
> 
> Git refuses to commit my change:
> 
> $ git cl land
> Using 50% similarity for rename/copy detection. Override with --similarity.
> Running presubmit commit checks ...
> Done processing
> /usr/local/google/home/regis/ssd/dart4/sdk/runtime/vm/class_table.h
> 
> Presubmit checks passed.
> No description set.
> Visit None/edit to set it.
> 
> 
> Is it confused by the fact that the description starts with "Fix"?

It's getting better and better:

$ git cl description
This branch has no associated changelist.

$ git status
# On branch slave
nothing to commit, working directory clean

Really? Let's see.

$ git diff master..slave
diff --git a/runtime/vm/class_table.h b/runtime/vm/class_table.h
index b62c71e..aebf15c 100644
--- a/runtime/vm/class_table.h
+++ b/runtime/vm/class_table.h
@@ -155,7 +155,7 @@ class ClassTable {
     return table_[index];
   }
 
-  intptr_t IsValidIndex(intptr_t index) const {
+  bool IsValidIndex(intptr_t index) const {
     return (index > 0) && (index < top_);
   }
 


Where did my change go?
It's the second time today I loose changes. Can we go back to svn?

[regis, 2015-08-04 23:44:53]

On 2015/08/04 23:33:39, regis wrote:
> On 2015/08/04 23:23:08, regis wrote:
> > On 2015/08/04 23:17:29, siva wrote:
> > > lgtm
> > 
> > Git refuses to commit my change:
> > 
> > $ git cl land
> > Using 50% similarity for rename/copy detection. Override with --similarity.
> > Running presubmit commit checks ...
> > Done processing
> > /usr/local/google/home/regis/ssd/dart4/sdk/runtime/vm/class_table.h
> > 
> > Presubmit checks passed.
> > No description set.
> > Visit None/edit to set it.
> > 
> > 
> > Is it confused by the fact that the description starts with "Fix"?
> 
> It's getting better and better:
> 
> $ git cl description
> This branch has no associated changelist.
> 
> $ git status
> # On branch slave
> nothing to commit, working directory clean
> 
> Really? Let's see.
> 
> $ git diff master..slave
> diff --git a/runtime/vm/class_table.h b/runtime/vm/class_table.h
> index b62c71e..aebf15c 100644
> --- a/runtime/vm/class_table.h
> +++ b/runtime/vm/class_table.h
> @@ -155,7 +155,7 @@ class ClassTable {
>      return table_[index];
>    }
>  
> -  intptr_t IsValidIndex(intptr_t index) const {
> +  bool IsValidIndex(intptr_t index) const {
>      return (index > 0) && (index < top_);
>    }
>  
> 
> 
> Where did my change go?
> It's the second time today I loose changes. Can we go back to svn?

OK, I figured out magic incantations to reassign the issue number to the current
cl in order to edit its description:

$ git cl issue
Issue number: None (None)


$ git cl issue 1271013005
Issue number: 1271013005 (https://codereview.chromium.org//1271013005)

$ git cl description

Fix typo -> This fixes a typo

$ git cl land

[regis, 2015-08-04 23:46:13]

Committed patchset #1 (id:1) manually as
5e2dbbbba42c011a54d5716ff6cd27b1f4a6e2b4 (presubmit successful).