Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1269833003: Mark Dartium and content shell as isDartVM. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark Dartium and content shell as isDartVM. Also rename TestPlatform.isDartVm to isDartVM to match the style guide for two-letter acronyms. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/392544a9e85d4848b4813d30c09edbc46a5bae4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/backend/platform_selector/evaluator.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/test_platform.dart View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
5 years, 4 months ago (2015-07-30 20:00:20 UTC) #2
kevmoo
lgtm
5 years, 4 months ago (2015-07-30 20:03:43 UTC) #3
nweiz
5 years, 4 months ago (2015-07-30 20:08:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
392544a9e85d4848b4813d30c09edbc46a5bae4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698