Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: lib/src/backend/test_platform.dart

Issue 1269833003: Mark Dartium and content shell as isDartVM. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/src/backend/platform_selector/evaluator.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.backend.test_platform; 5 library test.backend.test_platform;
6 6
7 // TODO(nweiz): support pluggable platforms. 7 // TODO(nweiz): support pluggable platforms.
8 /// An enum of all platforms on which tests can run. 8 /// An enum of all platforms on which tests can run.
9 class TestPlatform { 9 class TestPlatform {
10 // When adding new platforms, be sure to update the baseline and derived 10 // When adding new platforms, be sure to update the baseline and derived
11 // variable tests in test/backend/platform_selector/evaluate_test. 11 // variable tests in test/backend/platform_selector/evaluate_test.
12 12
13 /// The command-line Dart VM. 13 /// The command-line Dart VM.
14 static const TestPlatform vm = 14 static const TestPlatform vm =
15 const TestPlatform._("VM", "vm", isDartVm: true); 15 const TestPlatform._("VM", "vm", isDartVM: true);
16 16
17 /// Dartium. 17 /// Dartium.
18 static const TestPlatform dartium = const TestPlatform._("Dartium", "dartium", 18 static const TestPlatform dartium = const TestPlatform._("Dartium", "dartium",
19 isBrowser: true, isBlink: true); 19 isBrowser: true, isBlink: true, isDartVM: true);
20 20
21 /// Dartium content shell. 21 /// Dartium content shell.
22 static const TestPlatform contentShell = const TestPlatform._( 22 static const TestPlatform contentShell = const TestPlatform._(
23 "Dartium Content Shell", "content-shell", 23 "Dartium Content Shell", "content-shell",
24 isBrowser: true, isBlink: true); 24 isBrowser: true, isBlink: true, isDartVM: true);
25 25
26 /// Google Chrome. 26 /// Google Chrome.
27 static const TestPlatform chrome = const TestPlatform._("Chrome", "chrome", 27 static const TestPlatform chrome = const TestPlatform._("Chrome", "chrome",
28 isBrowser: true, isJS: true, isBlink: true); 28 isBrowser: true, isJS: true, isBlink: true);
29 29
30 /// PhantomJS. 30 /// PhantomJS.
31 static const TestPlatform phantomJS = const TestPlatform._( 31 static const TestPlatform phantomJS = const TestPlatform._(
32 "PhantomJS", "phantomjs", 32 "PhantomJS", "phantomjs",
33 isBrowser: true, isJS: true, isBlink: true); 33 isBrowser: true, isJS: true, isBlink: true);
34 34
(...skipping 29 matching lines...) Expand all
64 all.firstWhere((platform) => platform.identifier == identifier, 64 all.firstWhere((platform) => platform.identifier == identifier,
65 orElse: () => null); 65 orElse: () => null);
66 66
67 /// The human-friendly name of the platform. 67 /// The human-friendly name of the platform.
68 final String name; 68 final String name;
69 69
70 /// The identifier used to look up the platform. 70 /// The identifier used to look up the platform.
71 final String identifier; 71 final String identifier;
72 72
73 /// Whether this platform runs the Dart VM in any capacity. 73 /// Whether this platform runs the Dart VM in any capacity.
74 final bool isDartVm; 74 final bool isDartVM;
75 75
76 /// Whether this platform is a browser. 76 /// Whether this platform is a browser.
77 final bool isBrowser; 77 final bool isBrowser;
78 78
79 /// Whether this platform runs Dart compiled to JavaScript. 79 /// Whether this platform runs Dart compiled to JavaScript.
80 final bool isJS; 80 final bool isJS;
81 81
82 /// Whether this platform uses the Blink rendering engine. 82 /// Whether this platform uses the Blink rendering engine.
83 final bool isBlink; 83 final bool isBlink;
84 84
85 const TestPlatform._(this.name, this.identifier, {this.isDartVm: false, 85 const TestPlatform._(this.name, this.identifier, {this.isDartVM: false,
86 this.isBrowser: false, this.isJS: false, this.isBlink: false}); 86 this.isBrowser: false, this.isJS: false, this.isBlink: false});
87 87
88 String toString() => name; 88 String toString() => name;
89 } 89 }
OLDNEW
« no previous file with comments | « lib/src/backend/platform_selector/evaluator.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698