Issue 1268783002: Fix inlining information:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1268783002: Fix inlining information: (Closed)

Created:
5 years, 4 months ago by srdjan

Modified:
5 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix inlining information: Missing caller inlining id chain left the inlining chain truncated and incorrect. Added full mapping: inlining-id to caller-inlining-id. Remove fix from https://codereview.chromium.org/1259243005/ Added some of changes from https://codereview.chromium.org/1260163006/ BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/cc1b7f0c3e0fbd39ed0f24d2af7e2d25d1aa9dd0

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -57 lines)			Patch
M	runtime/vm/compiler.cc	View	1	3 chunks	+30 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		7 chunks	+33 lines, -17 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View		6 chunks	+64 lines, -23 lines	0 comments	Download
M	runtime/vm/profiler_service.cc	View		2 chunks	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

srdjan

5 years, 4 months ago (2015-07-30 21:47:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
cc1b7f0c3e0fbd39ed0f24d2af7e2d25d1aa9dd0 (presubmit successful).