Implement optional parameter handling in ARM vm.

Implement optional parameter handling in ARM vm.
Enable FindCodeObject test on ARM (production mode only for now).
Make sure the object pool is allocated in the old space.
Some more code cleanup on IA32 and X64 (use named constants).
Committed: https://code.google.com/p/dart/source/detail?r=20399

[zra, 2013-03-22 16:45:10]

https://codereview.chromium.org/12663024/diff/1/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/12663024/diff/1/runtime/tests/vm/vm.status#ne...
runtime/tests/vm/vm.status:77: cc/FindCodeObject: Crash
Are there any tests that can be enabled now for the optional parameter handling?

https://codereview.chromium.org/12663024/diff/1/runtime/vm/flow_graph_compile...
File runtime/vm/flow_graph_compiler_arm.cc (right):

https://codereview.chromium.org/12663024/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:170: __ Comment("Copy parameters");
Maybe add a comment explaining register contents on entry since R5 is used for
something other than ic data below.

https://codereview.chromium.org/12663024/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:252: // Let R7 point to the first passed
argument, i.e. to fp[1 + argc - 0].
Is this comment outdated?

https://codereview.chromium.org/12663024/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:293: __ Bind(&next_parameter);
Does anything branch to here?

[regis, 2013-03-22 17:26:11]

Thanks!

PTAL

https://codereview.chromium.org/12663024/diff/1/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/12663024/diff/1/runtime/tests/vm/vm.status#ne...
runtime/tests/vm/vm.status:77: cc/FindCodeObject: Crash
On 2013/03/22 16:45:10, zra wrote:
> Are there any tests that can be enabled now for the optional parameter
handling?

I had to implement support for optional parameters, because FindCodeObject
requires it. For now, it is only running in unchecked mode. Besides
FindCodeObject, there are many tests for optional parameters, however, it is
still too early to enable them. My goal is to make sure all vm tests pass before
I enable the Dart tests.

https://codereview.chromium.org/12663024/diff/1/runtime/vm/flow_graph_compile...
File runtime/vm/flow_graph_compiler_arm.cc (right):

https://codereview.chromium.org/12663024/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:170: __ Comment("Copy parameters");
On 2013/03/22 16:45:10, zra wrote:
> Maybe add a comment explaining register contents on entry since R5 is used for
> something other than ic data below.

Added comment here and in FlowGraphCompiler::CompileGraph().
R5 is free to be used. It is reloaded with ic-data if needed. Same code as on
IA32 and X64.

https://codereview.chromium.org/12663024/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:252: // Let R7 point to the first passed
argument, i.e. to fp[1 + argc - 0].
On 2013/03/22 16:45:10, zra wrote:
> Is this comment outdated?

Yes. I forgot to remove the old version. The newer version is below.

https://codereview.chromium.org/12663024/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:293: __ Bind(&next_parameter);
On 2013/03/22 16:45:10, zra wrote:
> Does anything branch to here?

Good catch. This is left over code from a previous version supporting optional
parameters with different semantics. Removed here and in the ia32 and x64
versions.

[zra, 2013-03-22 17:39:03]

LGTM

[regis, 2013-03-22 18:30:43]

Committed patchset #2 manually as r20399 (presubmit successful).