Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 12663024: Implement optional parameter handling in ARM vm. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm.h ('k') | runtime/vm/find_code_object_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.cc
===================================================================
--- runtime/vm/assembler_arm.cc (revision 20390)
+++ runtime/vm/assembler_arm.cc (working copy)
@@ -1262,6 +1262,9 @@
void Assembler::LoadObject(Register rd, const Object& object) {
+ // Since objects in the VM heap are never relocated, test instead
+ // if (object.IsSmi() || object.InVMHeap()) {
+ // and modify the decoding code in CallPattern to understand movt, movw.
if (object.IsNull() ||
object.IsSmi() ||
(object.raw() == Bool::True().raw()) ||
@@ -1282,6 +1285,13 @@
}
+void Assembler::CompareObject(Register rn, const Object& object) {
+ ASSERT(rn != IP);
+ LoadObject(IP, object);
+ cmp(rn, ShifterOperand(IP));
+}
+
+
void Assembler::Bind(Label* label) {
ASSERT(!label->IsBound());
int bound_pc = buffer_.Size();
@@ -1919,6 +1929,8 @@
int32_t Assembler::AddObject(const Object& obj) {
+ ASSERT(obj.IsNotTemporaryScopedHandle());
+ ASSERT(obj.IsOld());
if (object_pool_.IsNull()) {
// The object pool cannot be used in the vm isolate.
ASSERT(Isolate::Current() != Dart::vm_isolate());
« no previous file with comments | « runtime/vm/assembler_arm.h ('k') | runtime/vm/find_code_object_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698