Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 12663017: Reapply the expanded names with the correct form of requestFileSystem on the (Closed)

Created:
7 years, 9 months ago by Emily Fortuna
Modified:
7 years, 9 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply the expanded names with the correct form of requestFileSystem on the test. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20136

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -234 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 17 chunks +160 lines, -72 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 15 chunks +120 lines, -46 lines 0 comments Download
M tests/html/fileapi_test.dart View 6 chunks +13 lines, -19 lines 0 comments Download
M tests/html/mutationobserver_test.dart View 2 chunks +0 lines, -30 lines 0 comments Download
M tests/html/notifications_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 2 chunks +12 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 3 chunks +5 lines, -3 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +0 lines, -1 line 0 comments Download
D tools/dom/templates/html/dart2js/impl_Notification.darttemplate View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/dom/templates/html/dart2js/impl_WorkerContext.darttemplate View 1 chunk +0 lines, -24 lines 0 comments Download
A tools/dom/templates/html/impl/impl_DirectoryEntry.darttemplate View 1 chunk +47 lines, -0 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_EventSource.darttemplate View 1 chunk +5 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_MutationObserver.darttemplate View 2 chunks +1 line, -15 lines 0 comments Download
A tools/dom/templates/html/impl/impl_Notification.darttemplate View 1 chunk +22 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/dom/templates/html/impl/impl_WorkerContext.darttemplate View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
Reapplying https://codereview.chromium.org//12531013 There are two differences: - modified mutationobserver_test.dart (I changed the syntax for specifying ...
7 years, 9 months ago (2013-03-16 00:59:39 UTC) #1
blois
lgtm
7 years, 9 months ago (2013-03-16 01:01:18 UTC) #2
Emily Fortuna
7 years, 9 months ago (2013-03-16 01:02:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20136 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698